Repository navigation
fix: raise badsecrets and baddns pins in attack-surface-management (ENG-8929) - #187
Merged
Merged
Conversation
…NG-8929) Match the versions bbot 3.0.2 requests (badsecrets~=1.2.1, baddns~=2.4.0). This resolves Django 5.2.x in place of 4.2.30. Bump version to 2.0.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Automated agent review — not a human approval. [REVIEW] — APPROVEBase: No blocking findings. The diff changes only the pin and version lines that ENG-8929 R1–R4 name. Independent checks (Python 3.13, linux/amd64):
|
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrow and consistent, with reported dependency resolution, smoke tests, and regression checks supporting compatibility.
No open issues 🎉
What changed in this PR
Updates attack-surface-management dependencies to align with BBOT 3.0.2 and address the reported Django vulnerabilities.
Changes:
- Raises
badsecretsandbaddnsconstraints consistently across all three installation paths. - Bumps the capability and project versions to
2.0.4.
| File | Description |
|---|---|
| capabilities/attack-surface-management/pyproject.toml | Updates dependency constraints and project version. |
| capabilities/attack-surface-management/mcp/bbot.py | Matches inline script dependency constraints. |
| capabilities/attack-surface-management/capability.yaml | Updates sandbox dependencies and capability version. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raise the
badsecretsandbaddnspins in attack-surface-management to the versions bbot 3.0.2 requests. This moves Django from 4.2.30 (CVE-2025-27556, CVE-2026-15307) to 5.2.18, which has no known OSV advisories.~=0.13.47~=1.2.1~=1.12.294~=2.4.0Linear: ENG-8929
Changes
capability.yaml— two pins; version 2.0.3 → 2.0.4pyproject.toml— same two pins; version 2.0.3 → 2.0.4mcp/bbot.py— same two pins in the PEP 723 headerNo other dependency lines change.
pyOpenSSL,dnspython, andtldextractare untouched.Acceptance evidence
Python 3.13, linux/amd64, in
capabilities/attack-surface-management:uv export --script mcp/bbot.py --python 3.13 --no-hashes→baddns==2.4.1,badsecrets==1.2.1,django==5.2.18capability.yamldependencies.python→ Django 5.2.18; OSV query returns{}uv run --python 3.13 --extra dev bbot -t example.com -m badsecrets baddns --no-deps --dry-run -y→Setup succeeded for 14/14 modules., no[ERRR]Regression evidence
uv run --python 3.13 --extra dev pytest tests -q→ 15 passedjust validate strict=true→ 26 validated: 20 ok, 6 warn, 0 failed. The warnings are missing local binaries (tlsx, alterx, asnmap, uncover, interactsh-client, protoscope).Notes
ruff-formatwanted to reformat about 115 lines ofmcp/bbot.py. That happens only in a dreadnode-tiger submodule checkout, where ruff uses dreadnode-tiger'spyproject.toml(line-length 120). With this repo's own settings,mcp/bbot.pyis already formatted. Those changes were left out.Base:
main@03504f72a00d3305af44884f870730b9430adfd9Head:
01b30c81d9ea8c4dff9f37d77ef7a6bb0b650048🤖 Generated with Claude Code