Repository navigation
ci(dependabot): explain the type change for indirect npm packages - #289
Merged
Merged
Conversation
Dependabot used the production prefix for a security update of an indirect npm dependency, so the PR got the type deps. All npm packages in this repository are tools and none is part of the Salesforce package, so both npm prefixes are now build. Co-Authored-By: Claude <noreply@anthropic.com>
…ckages Return the npm prefix to deps for production dependencies. The shared reusable workflow changes the type to build for indirect packages that only devDependencies need. Use the same header comment as the shared Dependabot configuration. Co-Authored-By: Claude <noreply@anthropic.com>
dschach
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Dependabot opened the security update PR #288 for
follow-redirectswith the typedeps.follow-redirectsis an indirect package that only development dependencies need, so the correct type isbuild. Dependabot used the production prefix for this indirect package. The shared reusable Dependabot workflow now corrects the type frompackage-lock.json. This PR keeps the prefixes as they are and explains the type change in the configuration.Changes
Dependabot configuration
Use the same
.github/dependabot.ymltext as the shared configuration repository. The only difference is anignorerule there that is for that repository only.Add a comment that explains that Dependabot can use
depsfor an indirect npm package, and that the workflow changes the type tobuildwhen only development dependencies need the package.The comment now says "the Dependabot workflow, which calls dependabot-reusable.yml" and not a file name, because the caller file has a different name in each repository.
The prefixes stay the same:
depsfor production dependencies,buildfor development dependencies, andcifor GitHub Actions.Behavior notes
This PR changes a comment only. The new behavior comes from the shared workflow, which this repository already calls.
The comment uses general words, so the same text can go into other repositories.
Test plan
The YAML parses, and Prettier passes.
Merge this PR after the shared workflow change, so that the comment describes behavior that exists.
The next Dependabot security update for an indirect development package gets a title that starts with
build(.🤖 Generated with Claude Code