Document heterogeneous node groups for tasks - #4154
Open
Bihan wants to merge 1 commit into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
peterschmidt85
approved these changes
Aug 17, 2026
peterschmidt85
left a comment
Contributor
There was a problem hiding this comment.
- Do you think we could also add "???" (collapsible) section with P/D example?
- Do you think it would make sense to also re-write our
mpirunand ray examples - and link them from here?
| `${{ groups[i].nodes[j].IP_ADDRESS }}`, where `i` is the index of the group in `groups` and `j` is | ||
| the index of the node within that group. | ||
|
|
||
| Node `groups[0].nodes[0]` is the run's master node — it is what `DSTACK_MASTER_NODE_IP` resolves |
Contributor
There was a problem hiding this comment.
IMO, this can use a blockquote to highlight this?
Collaborator
Author
P/D is a service setup, and the next PR switches services from replicas: to groups: and adds interpolation. I think it would be better to add it once that PR lands, when the example can use groups: and ${{ groups[i].replicas[j].IP_ADDRESS }}.
|
Contributor
I meant adding a task example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nodes/resources/commands/portsand${{ groups[i].nodes[j].IP_ADDRESS }}references.