Conversation
not needed, put the methods in the mode_field_plot module
…nter/METplotpy into feature_560_mode_field_plot
…entation. Removed hard-coded pathnames
…onfig which supports ENV vars in yaml config file
…nter/METplotpy into feature_560_mode_field_plot
…bsequent plots using the same data and configuration to ensure no changes have transpired
…o address apply_theta_transforms becoming deprecated in Matplotlib 3.11
23 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
generated pytests to verify plots are generated
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
code is set up on 'seneca': /d1/projects/MODE_Field_Plot with instructions for setting up PYTHONPATH, conda environment to use, and running the plot
User Documentation: ReadtheDocs.io
https://metplus.readthedocs.io/projects/metplotpy/en/feature_560_mode_field_plot
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [Yes]
If yes, please describe:
Quality gate threshold for test coverage may not be met
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases