Repository navigation
dbar: animate hiding overlay bars on fullscreen in niri - #4000
Open
steven12138 wants to merge 3 commits into
Open
steven12138 wants to merge 3 commits into
steven12138 wants to merge 3 commits into
Conversation
4 of 5 tasks
Author
2026-10-29.00-30-18-compressed.mp4 |
Member
|
/claude review |
Contributor
Claude reviewNo issues found. |
bbedward
requested changes
Oct 29, 2026
| @@ -0,0 +1,161 @@ | |||
| import assert from 'node:assert/strict'; | |||
| import { readFileSync } from 'node:fs'; | |||
Member
There was a problem hiding this comment.
I dotn really want to add these new tests for this
bbedward
requested changes
Oct 29, 2026
| @@ -0,0 +1,34 @@ | |||
| # Fullscreen bar auto-hide on niri | |||
|
|
|||
| In Settings > Bar, enable **Use overlay layer**, then **Hide bar on fullscreen** | |||
Member
There was a problem hiding this comment.
Documentation like this shouldnt be here
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an opt-in Hide bar on fullscreen setting for overlay bars on niri. When the active window on an output enters fullscreen, DBar slides the top bar away with its existing auto-hide animation. It slides back on exit. The theme controls transition duration, including disabled animations, and the pointer can reveal the hidden bar from the screen edge.
The setting defaults to off and requires Use overlay layer. It does not enable global auto-hide or change the bar's layer. Fullscreen-only hiding keeps the configured exclusive zone, so it does not cause other windows to relayout on entry or exit. Existing global auto-hide still releases the zone as before. Frame-hosted bars, islands, and other compositors are unaffected.
This is the Dux 2.0
DBarport of #3335. It incorporates the earlier review fixes:bar toggleRevealdoes not prevent the next fullscreen hide.Niri IPC and Wayland toplevels have no shared window ID. Matching uses exact app ID and title on the output, with keyboard focus as a disambiguator. If a match remains ambiguous, the bar stays visible.
Validation
node --test quickshell/tests/bar-ipc.test.mjs quickshell/tests/niri-workspace-state.test.mjs: passed after the review changes.make test-qml: Qt 31 passed, lock 38 passed, logic passed before the review changes.dux-shell 2.0.0-3built and installed locally before the review changes. A plaindms restartloaded the embedded patch. Fullscreen entry and exit were checked in a single-monitor niri session, and the user confirmed the behavior works.git diff --check: passed.The exclusive-zone behavior has not been measured live. Pointer-edge behavior and physical multi-monitor behavior have not been checked separately on Dux 2.0.
make lint-qmlcould not run in the fresh worktree because Quickshell's VFS.qmlls.inihad not been generated.