Repository navigation
tray: open overflow item menus at the icon - #4002
Merged
bbedward merged 1 commit intoOct 29, 2026
Merged
Conversation
The overflow grid bound overflowPopout to itself, so the popup offset was never added and right-click menus opened at the left screen edge.
Member
|
/claude review |
Contributor
Claude reviewNo issues found. The fix is correct: |
dux-ci Bot
pushed a commit
that referenced
this pull request
Oct 29, 2026
port 2.0 (cherry picked from commit a1c8db2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Right-clicking a tray icon inside the overflow popup opens its menu at the left edge of the screen instead of under the icon.
In
SystemTrayBar.qmlthe overflow grid is created withoverflowPopout: overflowPopout. InsideTrayOverflowGrid, the right-hand side resolves to the grid's own (unset)overflowPopoutproperty rather than theDPopoutid, so it staysundefined.TrayOverflowGridthen adds no popup offset, and the popup-local click position (about 33 px) is passed on as a screen coordinate.The fix binds through a typed property on the bar root (
root.overflowPopoutRef).Measured on a 1920 px top bar, standalone popouts, niri:
gx33, menu at x 4gx1496, menu at x 1384–1600, under the iconType of change
Related issues
None found.
Screenshots / video
Before: the menu opens at the top-left corner while the icon sits in the overflow popup on the right.
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings