Repository navigation
Add GraphQL mapper unit test and fix smart meter Zigbee channel - #477
Merged
Merged
Conversation
Hilo nous retourne zigBeeChannel, petit typo.
Merged
Moustachauve
approved these changes
Oct 26, 2026
Ruff flags the missing trailing newline (W292). The pre-commit ruff hooks only cover pyhilo/ today, so CI did not catch it; fixing it here keeps this PR green once the hooks are extended to tests/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smart meter mapper checked for
zigbeeChannel, but Hilo sendszigBeeChannel(see
doc/graphql/onAnyDeviceUpdated-meter.json), so theZigbeeChannelattribute was never reported for meters.
Adds a unit test that maps the captured meter payload, and fixes the key casing.
Connection-state handling (
Disconnected) is left unchanged until we capture apayload from a disconnected device.