QCDL Examples by qci-keen · Pull Request #88 · dwavesystems/dwave-gate

qci-keen · 2026-09-14T22:10:07Z

This PR adds QCDL/qiskit examples that demonstrate unique aspects of QCDL and dual-rail qubits.

codecov · 2026-09-14T22:12:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.99%. Comparing base (26c1c3b) to head (4650143).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files          34       34           
  Lines        5683     5683           
=======================================
  Hits         5171     5171           
  Misses        512      512

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

JoelPasvolsky

@qci-keen, I have made some suggestions on the Classical Arithmetic file, I will try to review additional ones this afternoon.

Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

JoelPasvolsky

Added some suggestions for classical registers and measurement-based feedback. Will go on to the next three JNs now

JoelPasvolsky

Added suggestions on parallel Bell, RUS, and simple bell state JNs. Still need to look at the Bayesian example

Formatting and language changes Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

more formatting and language (the first batch was full so this is a second one). Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

remove old intialization Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

JoelPasvolsky

Comments from running the first 6 JNs, will do Bayesian and random circuit generation next.

One general thought: what about adding a README.rst file that gives a quick description of the examples and helps a new user decide in what order to run them (i.e., also ranks them from beginner to advanced)?

JoelPasvolsky · 2026-09-16T17:53:11Z

+
+# %% [markdown]
+# ## Conditional Branching & Registers
+


As a new user, things that would be unclear to me and would appreciate having described here in markdown, are:

c0 is updated based on measure(q0, register=c0) but c1 does not seem to be updated in the RTCF part of th ealgorithm

Why measure(q0, register=c0) for the first qubit but just measure(q1) for the second

Why with q1.If(c0 | c1 == 1) selects q1 for the method (could sc or q0 be used instead)?

@qci-amos could you help me with writing up an answer to this? Questions about scope and the inner workings of RTCF are not in my wheelhouse.

the example isn't intended to be meaningful, just illustrate some mechanics... we could update it to be slightly more meaningful? @qci-keen if you can think of something cute to show then we can update it, otherwise I suggest we just keep this as is (or omit it) and we can find something else later.

JoelPasvolsky · 2026-09-16T17:53:56Z

+    with q1.If(c0 | c1 == 1):
+        x(q1)  # X gate (bit flip)
+
+    measure(q1)


would this example be better if the above algorithm was in a loop that executed a few times so measurement of q1 would be in the RTCF?

thisac

Don't forget to add license headers to all files (they were missing in more files than the ones I commented on). This (normally) includes the __init__.py files, although they shouldn't be necessary at all here since the examples aren't part of the package structure.

JoelPasvolsky

Okay, @qci-keen, I think I've gone through all of it. These JNs will be very helpful for users, thank you!

thisac

I'd recommend removing the bayesian_decoding example from here and instead add it to the dwave-qiskit-plugin instead. It makes more sense having it where the dependencies are correct.

Language and typos Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

qci-amos · 2026-09-16T22:29:53Z

Ideally we wouldn't direct people to more than one place to find end-user examples for our system...

Formatting and job labels Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

thisac

Thanks @qci-keen for addressing my other comments. The examples look great, Just a couple of more things I noticed.

thisac · 2026-09-17T18:22:36Z

@@ -0,0 +1,15 @@
+# Copyright &copy; 2026 D-Wave


I don't think we need to add &copy here or elsewhere in the license headers. We don't have them in the other Python files. @JoelPasvolsky, do you know?

Suggested change

# Copyright © 2026 D-Wave

# Copyright 2026 D-Wave

Also, you should be able to remove the __init__.py files (this and one higher level) since this is not part of the package.

removed notice from __init__.py, waiting for decision on ©.

Sorry, I meant remove the files altogether. If kept, they should have the license.

thisac · 2026-09-17T18:38:52Z

+parent_dir = os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))
+sys.path.append(parent_dir)


Is this only for the rand_circ_fixed_hamming_weight import? If so, I'd recommend skipping it and instead just do

from random_circuit_generation import rand_circ_fixed_hamming_weight

which now should work since you moved that file next to bayesian_decoding_example.py.

It doesn't work for me to do that, must be something with which directory my vscode thinks is the base directory.

Strange, I thought it could have something to do with running it as a notebook vs just Python, but it works both ways for me.

what if you try:

from .random_circuit_generation import rand_circ_fixed_hamming_weight

?

add qcdl examples

f40cc2c

qci-keen assigned qci-keen and unassigned qci-keen Sep 14, 2026

qci-keen requested review from qci-amos and thisac September 15, 2026 16:21

qci-keen added the enhancement New feature or request label Sep 15, 2026

qci-keen marked this pull request as ready for review September 15, 2026 16:21

qci-amos reviewed Sep 15, 2026

View reviewed changes

Comment thread examples/classical_registers.py

qci-amos requested a review from JoelPasvolsky September 15, 2026 16:38

qci-keen marked this pull request as draft September 15, 2026 16:52

bayesian decoding example

8bb4a6b

qci-keen removed the enhancement New feature or request label Sep 15, 2026

JoelPasvolsky reviewed Sep 15, 2026

View reviewed changes

qci-keen and others added 10 commits September 15, 2026 12:27

Update examples/classical-arithmetic.py

9b768cd

Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

Update examples/classical-arithmetic.py

ed84060

Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

Update examples/classical-arithmetic.py

12a448d

Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

Update examples/classical-arithmetic.py

ff68614

Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

Update examples/classical-arithmetic.py

7fe7a51

Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

Update examples/classical-arithmetic.py

bbfa0eb

Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

Update examples/classical-arithmetic.py

123fb48

Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

Update examples/classical-arithmetic.py

0bbf711

Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

Update examples/classical-arithmetic.py

ef572ce

Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

dash to underscore makes ruff happier

d8244e4

JoelPasvolsky reviewed Sep 15, 2026

View reviewed changes

Comment thread examples/error_detection_handling/bayesian_decoding/README.md

JoelPasvolsky reviewed Sep 15, 2026

View reviewed changes

qci-keen and others added 2 commits September 15, 2026 15:16

remove dash file name

5fd6970

Apply batched suggestions from code review

959195f

Formatting and language changes Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

qci-keen and others added 2 commits September 15, 2026 15:34

Apply batched suggestions from code review

e3368f1

more formatting and language (the first batch was full so this is a second one). Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

remove weird extra space

9988958

qci-amos approved these changes Sep 15, 2026

View reviewed changes

JoelPasvolsky reviewed Sep 16, 2026

View reviewed changes

Comment thread examples/rus_simple.py Outdated

Apply batched suggestions from code review

7da9f2f

remove old intialization Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

qci-keen marked this pull request as ready for review September 16, 2026 16:21

JoelPasvolsky reviewed Sep 16, 2026

View reviewed changes

Comment thread examples/rus_simple.py

JoelPasvolsky reviewed Sep 16, 2026

View reviewed changes

thisac reviewed Sep 16, 2026

View reviewed changes

Comment thread examples/error_detection_handling/bayesian_decoding/bayesian_decoder.py

Comment thread examples/classical_arithmetic.py Outdated

Comment thread examples/error_detection_handling/bayesian_decoding/random_circuit_generation.py

JoelPasvolsky reviewed Sep 16, 2026

View reviewed changes

move and fix licenses

53eafd7

thisac reviewed Sep 16, 2026

View reviewed changes

qci-keen and others added 3 commits September 16, 2026 14:31

Apply batched suggestions from code review

1c47e1a

Language and typos Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

add some descriptions, fix import, make qiskit visualization optional

29c05ba

add copyright

30e01c0

Apply batched suggestions from code review

7ec35fc

Formatting and job labels Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

JoelPasvolsky reviewed Sep 17, 2026

View reviewed changes

Comment thread examples/rus_simple.py Outdated

qci-keen and others added 6 commits September 17, 2026 09:28

Update examples/rus_simple.py

ea6340d

Co-authored-by: Joel Pasvolsky <34041130+JoelPasvolsky@users.noreply.github.com>

move utils to bayesian decoding folder

0048d8d

additions to address comments

c4dfeb2

every file has copyright notice

3bc5933

fix docstring

2fe1031

add qiskit plugin to dependency group

6ad612b

thisac reviewed Sep 17, 2026

View reviewed changes

qci-keen added 2 commits September 17, 2026 12:43

remove copyright

2f8aec5

docstrings

4650143

		parent_dir = os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))
		sys.path.append(parent_dir)

Conversation

qci-keen commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

JoelPasvolsky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoelPasvolsky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoelPasvolsky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoelPasvolsky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qci-keen commented Sep 14, 2026 •

edited

Loading

codecov Bot commented Sep 14, 2026 •

edited

Loading

thisac left a comment •

edited

Loading