Repository navigation
Add Grid for surveying Zephyr topologies - #291
Open
mahdiehmalekian wants to merge 5 commits into
Open
mahdiehmalekian wants to merge 5 commits into
mahdiehmalekian wants to merge 5 commits into
Conversation
SebastianGitt
left a comment
SebastianGitt
left a comment
There was a problem hiding this comment.
Looks good, but I think many of the methods would be more readable if they had more descriptive variable names.
SebastianGitt
left a comment
SebastianGitt
left a comment
There was a problem hiding this comment.
Just took another pass with some higher-level observations and suggestions.
SebastianGitt
approved these changes
Sep 14, 2026
thisac
requested changes
Sep 15, 2026
thisac
left a comment
thisac
left a comment
Contributor
There was a problem hiding this comment.
Thanks @mahdiehmalekian. I'd like to do a more thorough review.
Build Grid entirely in __init__ (remove from_graph) Bump dwave-graphs to >=1.2 to use zephyr_coordinates.zephyr_to_cartesian instead of a local conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
minorminer.utils._clique.grid, another internal piece of the Zephyr clique embedder, afterel_geometry(#289) andmaximum_bipartite_matching(#290).Gridsurveys a possibly-faulty Zephyr topology once, at construction, into tables the clique embedder then queries directly. Tests are intests/utils/clique/test_grid.py.AI use: I used Claude to clean up and edit documentation of the
grid.pyand to generate thetest_grid.py. Checked and edited myself.Note to reviewers: This is part of a larger Zephyr clique embedder effort and subsequent clique-embedder PRs depend on this PR and can only follow once this merges. Would appreciate a speedy review.