chore(deps): vite 8 and the marko toolchain - #926
Conversation
|
fdc69a6 to
1dbec5e
Compare
|
Merge-order note: this PR and #924 (typescript 6) are each green independently, but once both are merged, ebayui-core's |
6ff93a4 to
bb04a9c
Compare
vite 8, @marko/vite 6, @marko/run 0.11, @storybook/marko-vite 5, vite-css-modules 1.16, marko 6.3.48, and @marko/type-check 3, which actually type-checks the docs site. Site changes: regenerate .marko-run/routes.d.ts with @marko/run 0.11 (restores typed $global.meta), switch scss module imports to default imports with exportMode 'both' as a workaround for the type-checker ignoring the generated scss declarations (filed in agent-feedback), declare @eBay/skin and @docsearch/css side-effect imports, migrate the root tsconfig off node10 resolution, and refresh a snapshot for marko's new compiled output. ebayui-core keeps marko 5.38 pinned in the lock; 5.39's type changes break its type-check (filed in agent-feedback). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@marko/type-check 3 nests TypeScript 6, which hard-errors on the package's CommonJS-era node10 moduleResolution. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bb04a9c to
680b550
Compare
|
Correction to my earlier merge-order note: no coupling with #924 after all. @marko/type-check 3 nests its own TypeScript 6, so the |
PR Preview DeployedWebsite • commit e357d37 |
Nothing in the toolchain reads the generated *.module.scss.d.ts files: no .ts file imports a scss module and the marko type-checker does not consult sibling declarations (see agent-feedback). They only churn on every site build. Re-enable generateSourceTypes when the checker learns to use them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Use module preserve with bundler resolution instead of silencing the TS 6 deprecation, and add the types export condition to the @internal shim packages — they ship declarations, but exports maps without a types condition hide them from modern resolution. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
.marko-run and the skin dist output are build artifacts; marking them linguist-generated collapses them in GitHub review and drops them from diff stats. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 participant
Updates the interlocked vite/marko cluster: vite 8, @marko/vite 6, @marko/run 0.11, @storybook/marko-vite 5, vite-css-modules 1.16, marko 6.3.48, and @marko/type-check 3. The new type-checker actually checks the docs site, requiring: scss module imports switched to default imports, typing for $global.meta/$global.url, declarations for @ebay/skin and @docsearch/css side-effect imports, migrating the root tsconfig off the removed node10 resolution, and a snapshot refresh for marko's new compiled output. ebayui-core's nested marko 5 stays lock-pinned at 5.38.38 — marko 5.39's type changes break its type-check (filed in agent-feedback).
🤖 Generated with Claude Code