Skip to content

refactor(sample)!: CRUD 반환 계약과 페이징 처리 및 MyBatis 매핑 개선 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeeBaekHaeng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(sample)!: CRUD 반환 계약과 페이징 처리 및 MyBatis 매핑 개선 #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/main/java/egovframework/example/sample/service/EgovSampleService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,44 +36,44 @@ public interface EgovSampleService {

/**
* 글을 등록한다.
* @param vo - 등록할 정보가 담긴 SampleVO
* @param sampleVO - 등록할 정보가 담긴 SampleVO
* @return 등록 결과
*/
void insertSample(SampleVO vo);
int insertSample(SampleVO sampleVO);

/**
* 글을 수정한다.
* @param vo - 수정할 정보가 담긴 SampleVO
* @param sampleVO - 수정할 정보가 담긴 SampleVO
* @return void형
*/
void updateSample(SampleVO vo);
int updateSample(SampleVO sampleVO);

/**
* 글을 삭제한다.
* @param vo - 삭제할 정보가 담긴 SampleVO
* @param sampleVO - 삭제할 정보가 담긴 SampleVO
* @return void형
*/
void deleteSample(SampleVO vo);
int deleteSample(SampleVO sampleVO);

/**
* 글을 조회한다.
* @param vo - 조회할 정보가 담긴 SampleVO
* @param sampleVO - 조회할 정보가 담긴 SampleVO
* @return 조회한 글
*/
SampleVO selectSample(SampleVO vo);
SampleVO selectSample(SampleVO sampleVO);

/**
* 글 목록을 조회한다.
* @param vo - 조회할 정보가 담긴 VO
* @param sampleVO - 조회할 정보가 담긴 VO
* @return 글 목록
*/
List<?> selectSampleList(SampleVO vo);
List<SampleVO> selectSampleList(SampleVO sampleVO);

/**
* 글 총 개수를 조회한다.
* @param vo - 조회할 정보가 담긴 VO
* @param sampleVO - 조회할 정보가 담긴 VO
* @return 글 총 개수
*/
int selectSampleListTotCnt(SampleVO vo);
int selectSampleListTotCnt(SampleVO sampleVO);

}
4 changes: 2 additions & 2 deletions src/main/java/egovframework/example/sample/service/SampleDefaultVO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ public class SampleDefaultVO implements Serializable {
private int pageIndex = 1;

/** 페이지개수 */
private int pageUnit = 10;
private Integer pageUnit;

/** 페이지사이즈 */
private int pageSize = 10;
private Integer pageSize;

/** firstIndex */
private int firstIndex = 1;
Expand Down
46 changes: 22 additions & 24 deletions src/main/java/egovframework/example/sample/service/impl/EgovSampleServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
* @version 1.0
* @see
*/
@Service("sampleService")
@Service
@RequiredArgsConstructor
@Slf4j
public class EgovSampleServiceImpl extends EgovAbstractServiceImpl implements EgovSampleService {
Expand All @@ -57,54 +57,52 @@ public class EgovSampleServiceImpl extends EgovAbstractServiceImpl implements Eg

/**
* 글을 등록한다.
* @param vo - 등록할 정보가 담긴 SampleVO
* @param sampleVO - 등록할 정보가 담긴 SampleVO
* @return 등록 결과
*/
@Override
public void insertSample(SampleVO vo) {
log.debug(vo.toString());
public int insertSample(SampleVO sampleVO) {
log.debug("id={}", sampleVO.getId());

/** ID Generation Service */
String id;
try {
id = egovIdGnrService.getNextStringId();
sampleVO.setId(egovIdGnrService.getNextStringId());
} catch (FdlException e) {
throw new BaseRuntimeException(e);
}
vo.setId(id);
log.debug(vo.toString());
log.debug("id={}", sampleVO.getId());

sampleMapper.insertSample(vo);
return sampleMapper.insertSample(sampleVO);
}

/**
* 글을 수정한다.
* @param vo - 수정할 정보가 담긴 SampleVO
* @param sampleVO - 수정할 정보가 담긴 SampleVO
* @return void형
*/
@Override
public void updateSample(SampleVO vo) {
sampleMapper.updateSample(vo);
public int updateSample(SampleVO sampleVO) {
return sampleMapper.updateSample(sampleVO);
}

/**
* 글을 삭제한다.
* @param vo - 삭제할 정보가 담긴 SampleVO
* @param sampleVO - 삭제할 정보가 담긴 SampleVO
* @return void형
*/
@Override
public void deleteSample(SampleVO vo) {
sampleMapper.deleteSample(vo);
public int deleteSample(SampleVO sampleVO) {
return sampleMapper.deleteSample(sampleVO);
}

/**
* 글을 조회한다.
* @param vo - 조회할 정보가 담긴 SampleVO
* @param sampleVO - 조회할 정보가 담긴 SampleVO
* @return 조회한 글
*/
@Override
public SampleVO selectSample(SampleVO vo) {
SampleVO resultVO = sampleMapper.selectSample(vo);
public SampleVO selectSample(SampleVO sampleVO) {
SampleVO resultVO = sampleMapper.selectSample(sampleVO);
if (resultVO == null) {
throw new BaseRuntimeException(processException("info.nodata.msg"));
}
Expand All @@ -113,22 +111,22 @@ public SampleVO selectSample(SampleVO vo) {

/**
* 글 목록을 조회한다.
* @param vo - 조회할 정보가 담긴 VO
* @param sampleVO - 조회할 정보가 담긴 VO
* @return 글 목록
*/
@Override
public List<?> selectSampleList(SampleVO vo) {
return sampleMapper.selectSampleList(vo);
public List<SampleVO> selectSampleList(SampleVO sampleVO) {
return sampleMapper.selectSampleList(sampleVO);
}

/**
* 글 총 개수를 조회한다.
* @param vo - 조회할 정보가 담긴 VO
* @param sampleVO - 조회할 정보가 담긴 VO
* @return 글 총 개수
*/
@Override
public int selectSampleListTotCnt(SampleVO vo) {
return sampleMapper.selectSampleListTotCnt(vo);
public int selectSampleListTotCnt(SampleVO sampleVO) {
return sampleMapper.selectSampleListTotCnt(sampleVO);
}

}
24 changes: 12 additions & 12 deletions src/main/java/egovframework/example/sample/service/impl/SampleMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,44 +43,44 @@ public interface SampleMapper {

/**
* 글을 등록한다.
* @param vo - 등록할 정보가 담긴 SampleVO
* @param sampleVO - 등록할 정보가 담긴 SampleVO
* @return 등록 결과
*/
void insertSample(SampleVO vo);
int insertSample(SampleVO sampleVO);

/**
* 글을 수정한다.
* @param vo - 수정할 정보가 담긴 SampleVO
* @param sampleVO - 수정할 정보가 담긴 SampleVO
* @return void형
*/
void updateSample(SampleVO vo);
int updateSample(SampleVO sampleVO);

/**
* 글을 삭제한다.
* @param vo - 삭제할 정보가 담긴 SampleVO
* @param sampleVO - 삭제할 정보가 담긴 SampleVO
* @return void형
*/
void deleteSample(SampleVO vo);
int deleteSample(SampleVO sampleVO);

/**
* 글을 조회한다.
* @param vo - 조회할 정보가 담긴 SampleVO
* @param sampleVO - 조회할 정보가 담긴 SampleVO
* @return 조회한 글
*/
SampleVO selectSample(SampleVO vo);
SampleVO selectSample(SampleVO sampleVO);

/**
* 글 목록을 조회한다.
* @param vo - 조회할 정보가 담긴 VO
* @param sampleVO - 조회할 정보가 담긴 VO
* @return 글 목록
*/
List<?> selectSampleList(SampleVO vo);
List<SampleVO> selectSampleList(SampleVO sampleVO);

/**
* 글 총 개수를 조회한다.
* @param vo - 조회할 정보가 담긴 VO
* @param sampleVO - 조회할 정보가 담긴 VO
* @return 글 총 개수
*/
int selectSampleListTotCnt(SampleVO vo);
int selectSampleListTotCnt(SampleVO sampleVO);

}
24 changes: 15 additions & 9 deletions src/main/java/egovframework/example/sample/web/EgovSampleController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import org.egovframe.rte.ptl.mvc.tags.ui.pagination.PaginationInfo;
import org.springframework.stereotype.Controller;
import org.springframework.ui.Model;
import org.springframework.ui.ModelMap;
import org.springframework.validation.BindingResult;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.ModelAttribute;
Expand Down Expand Up @@ -63,7 +62,7 @@ public class EgovSampleController {
private final EgovPropertyService propertiesService;

@GetMapping("/")
public String index(@ModelAttribute SampleVO sampleVO, ModelMap model) {
public String index(@ModelAttribute SampleVO sampleVO, Model model) {
return this.selectSampleList(sampleVO, model);
}

Expand All @@ -74,11 +73,15 @@ public String index(@ModelAttribute SampleVO sampleVO, ModelMap model) {
* @return "egovSampleList"
*/
@GetMapping("/egovSampleList.do")
public String selectSampleList(@ModelAttribute SampleVO sampleVO, ModelMap model) {
public String selectSampleList(@ModelAttribute SampleVO sampleVO, Model model) {

/** EgovPropertyService.sample */
sampleVO.setPageUnit(propertiesService.getInt("pageUnit"));
sampleVO.setPageSize(propertiesService.getInt("pageSize"));
if (sampleVO.getPageUnit() == null) {
sampleVO.setPageUnit(propertiesService.getInt("pageUnit"));
}
if (sampleVO.getPageSize() == null) {
sampleVO.setPageSize(propertiesService.getInt("pageSize"));
}

/** pageing setting */
PaginationInfo paginationInfo = new PaginationInfo();
Expand All @@ -91,7 +94,7 @@ public String selectSampleList(@ModelAttribute SampleVO sampleVO, ModelMap model
sampleVO.setRecordCountPerPage(paginationInfo.getRecordCountPerPage());

/** List */
List<?> sampleList = sampleService.selectSampleList(sampleVO);
List<SampleVO> sampleList = sampleService.selectSampleList(sampleVO);
model.addAttribute("resultList", sampleList);

/** Count */
Expand Down Expand Up @@ -132,7 +135,8 @@ public String addSample(@Valid @ModelAttribute SampleVO sampleVO, BindingResult
return "sample/egovSampleRegister";
}

sampleService.insertSample(sampleVO);
int result = sampleService.insertSample(sampleVO);
log.debug("result={}", result);
status.setComplete();

return "redirect:/egovSampleList.do";
Expand Down Expand Up @@ -172,7 +176,8 @@ public String updateSample(@Valid @ModelAttribute SampleVO sampleVO, BindingResu
return "sample/egovSampleRegister";
}

sampleService.updateSample(sampleVO);
int result = sampleService.updateSample(sampleVO);
log.debug("result={}", result);
status.setComplete();

redirectAttributes.addAttribute("searchCondition", sampleVO.getSearchCondition());
Expand All @@ -191,7 +196,8 @@ public String updateSample(@Valid @ModelAttribute SampleVO sampleVO, BindingResu
@PostMapping("/deleteSample.do")
public String deleteSample(@ModelAttribute SampleVO sampleVO, RedirectAttributes redirectAttributes, SessionStatus status) {

sampleService.deleteSample(sampleVO);
int result = sampleService.deleteSample(sampleVO);
log.debug("result={}", result);
status.setComplete();

redirectAttributes.addAttribute("searchCondition", sampleVO.getSearchCondition());
Expand Down
Loading