Repository navigation
Repair the tracked model only when the planner does - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The state node repaired seriality on every KD45 task, while the planner repairs only under
--kd45-repair, off by default since del-planner made it opt-in. On a KD45 task, an announcement that contradicts a belief left the planner's model with one world and the executor's with none, so the executor refused an action the policy had every reason to send.tracked_seriality()now followstask.repair_seriality(), as the planner does, and never refuses.backdoor-revealed.jsonis del-planner'sbackdoorwith a public announcement added. The new test applies both actions and fails onrollingwith "the update produced no state: non-serial".