Repository navigation
Move independent actions above a branch point - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing written below a sensing action started before its outcome was known, even when the outcome had no bearing on it. In the two-site survey, the south scan waited for the north one to be read, although it appears under both of its outcomes.
schedule_policyrearranges a policy before it is rendered:parallel_groups.Parallel, and members may now branch. Their outcomes then choose the continuation, one switch per member, with a copied member reading the outcome of the one that ran.Independence uses the same test as
parallel_groups, now exposed asmay_overlap.policy_to_btwith groups is now this renderer given the policy as written. Its XML is byte-identical torollingon the test policies, with and without groups.Two-site survey, measured locally (the same figures on two runs):
Before this change the parallel groups were the drives and then the north report beside the south scan, 12 s declared. 11 s is the minimum here: both reports go to
relay, so they run one after the other.policy_schedule_testruns every outcome combination through the schedule and checks that it runs the same actions as the written policy, in four steps.Unrelated, and on
rollingtoo:survey_sites_actionssometimes dies at shutdown (SIGSEGV/SIGBUS) on the host after the mission completes. It didn't happen in the Docker image.