Repository navigation
Leave the demo performers without their teardown - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the end of a mission, the launch file interrupts the demo performers. About one run in five then segfaulted after every action had finished (2 of 10 standalone interrupts). gdb puts the fault in the performer's destructor, run from
mainafterrclcpp::shutdown():CascadeLifecycleNodefrees itsactivators_state_map through a pointer that is no longer valid. No thread of the process is using the node at that point, only CycloneDDS's own.The three demo performers now end through
eplansys_demo::leave(), which shuts ROS down, flushes stdout and stderr, and leaves through_exit, skipping a teardown that has nothing left to do.plansys2_testsexits the same way for its own exit-time fault. The fault itself is in cascade_lifecycle, and fixing it there is a separate job.Checked locally:
ament_cpplintandament_uncrustifypass on the package.