fix: publish P4 completion after verified cleanup and enrichment - #21
Draft
echoomegaprime wants to merge 1 commit into
Draft
echoomegaprime wants to merge 1 commit into
echoomegaprime wants to merge 1 commit into
Conversation
Successful hostile acceptance reports omitted the completed_phase_gate field required by the master collector. Publish P4 only after every core check and cleanup succeeds, and keep exact-wrapper reports pending until enrichment returns. Failed verification, malformed capture, interruption and nonzero exit cannot leave a newly completed report for the master consumer. Keep master validation, exact-source and signing rules, release verdicts and historical acceptance reports unchanged. Add producer/wrapper/consumer integration coverage including pending publication and failure paths. Validation: 24 focused and adjacent tests pass; full suite 637 pass, 2 skip, 1 existing symlink test blocked by Windows privilege 1314. P1 acceptance passes all 3 scenarios using a byte-identical source copy outside historical artifacts. Hosted CI, dual certification and deployment remain pending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Successful P4 hostile acceptance reports omit
completed_phase_gate, so the master collector rejects them as incomplete. Publish the required P4 marker only after all core checks and cleanup succeed. The exact wrapper keeps intermediate output pending until evidence enrichment returns; verifier failure, malformed capture, interruption and nonzero exit remain blocked.The master consumer, signature and exact-source requirements, historical reports and release verdicts are unchanged. Completion of this phase remains distinct from whole-product readiness.
Evidence
a725d2e72b8b80f8a5e28a69422ffa3129ccd1e8(remote branch readback matched).WinError 1314) in the existingtest_workspace_owner_marker_and_symlink_detectiontest. No test was weakened or skipped to conceal that result.a725d2e72b8b80f8a5e28a69422ffa3129ccd1e8; its Linux suite passed all 640 tests. Artifact10680649225, named for the same SHA, has digestsha256:45fcb31937469843f3f3797b9172c2075e13bd795b963db11d6007dfc44ae3f3. The PR-only run tested temporary merge456e0f09f4dc7b7de391fe25cb5d3a279f801d36and is not used as exact-head proof.Security and release impact
Live service readiness additionally requires fresh source-bound P4 artifacts, valid image attestations, the expected public verification material, exact-tested CI evidence and the genuine signed whole-product report. This source fix does not claim those operational gates have passed.