Skip to content

Reporter and mesh update - #548

Open
rebeccathomas-NOAA wants to merge 11 commits into
echostack-org:mainfrom
rebeccathomas-NOAA:reporter_and_mesh_update
Open

rebeccathomas-NOAA wants to merge 11 commits into
echostack-org:mainfrom
rebeccathomas-NOAA:reporter_and_mesh_update

Conversation

@rebeccathomas-NOAA

@rebeccathomas-NOAA rebeccathomas-NOAA commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator
  • reporter.py was updated to use .to_numpy instead of .values.to_numpy , more consistent with current pandas usage.
  • Mesh cropping files were updated for 2011 and 2012 to reflect year-dependent transect mesh cropping parameters and to provide properly formatted transect bound inputs.

@leewujung

Copy link
Copy Markdown
Member

Hey @rebeccathomas-NOAA : I can see the changes now. Could you update the PR description to summarize what the changes are and why? Short bullet points are fine. Thanks!

@rebeccathomas-NOAA

Copy link
Copy Markdown
Collaborator Author
  • reporter.py was updated to use .to_numpy instead of .values.to_numpy , more consistent with current pandas usage.
  • Mesh cropping files were updated for 2011 and 2012 to reflect year-dependent transect mesh cropping parameters and to provide properly formatted transect bound inputs.

@leewujung

Copy link
Copy Markdown
Member

Oh you could edit the first comment so that it becomes the summary of the PR. :) I just did it so don't worry about it (I can edit the PR/issues as a maintainer), just for future reference.

@rebeccathomas-NOAA

Copy link
Copy Markdown
Collaborator Author

Let's hold off on this - I have another update in this branch. I think I want to wait to merge the binning code and then push up my branch with the reporter and mesh update as well as a stratify fix.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.values.to_numpy issues in reporter when running EchoPop_workflows

2 participants