Skip to content

add require valid location argument to provenance wrapper - #1809

Open
ctuguinay wants to merge 4 commits into
echostack-org:mainfrom
ctuguinay:main
Open

ctuguinay wants to merge 4 commits into
echostack-org:mainfrom
ctuguinay:main

Conversation

@ctuguinay

@ctuguinay ctuguinay commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Previously, not having location arguments in the output of consolidate.add_depth would print out xarray Dataset does not contain valid location data. Processing level attributes will not be added.

@codecov-commenter

codecov-commenter commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.75%. Comparing base (6cf6cee) to head (086927e).
⚠️ Report is 402 commits behind head on main.

Files with missing lines Patch % Lines
echopype/utils/prov.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1809      +/-   ##
==========================================
+ Coverage   85.58%   85.75%   +0.17%     
==========================================
  Files          79       80       +1     
  Lines        6998     7554     +556     
==========================================
+ Hits         5989     6478     +489     
- Misses       1009     1076      +67     
Flag Coverage Δ
integration 81.66% <80.00%> (+1.02%) ⬆️
unit 59.08% <80.00%> (-1.34%) ⬇️
unittests ?
windows-integration 80.92% <80.00%> (?)
windows-unit 59.09% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants