Skip to content

Cppcheck and GCC build warning fixes - #65

Open
sshedi wants to merge 34 commits into
ecki:masterfrom
sshedi:sshedi-fixes
Open

Cppcheck and GCC build warning fixes#65
sshedi wants to merge 34 commits into
ecki:masterfrom
sshedi:sshedi-fixes

Conversation

@sshedi

@sshedi sshedi commented May 26, 2026

Copy link
Copy Markdown

This patch series addresses a bunch of items from https://github.com/ecki/net-tools/blob/master/TODO
Please let me know your feedback @ecki

@sshedi sshedi changed the title Sshedi fixes Cppcheck and GCC build warning fixes May 26, 2026
@sshedi

sshedi commented May 26, 2026

Copy link
Copy Markdown
Author

My build host details:

$ cat /etc/os-release
NAME="Fedora Linux"
VERSION="45 (Rawhide Prerelease)"
RELEASE_TYPE=development
ID=fedora
VERSION_ID=45
VERSION_CODENAME=""
PRETTY_NAME="Fedora Linux 45 (Rawhide Prerelease)"

And toolchain:

$ rpm -q cppcheck gcc
cppcheck-2.20.1-1.fc45.x86_64
gcc-16.1.1-2.fc45.x86_64

@sshedi

sshedi commented Jun 9, 2026

Copy link
Copy Markdown
Author

Hi @ecki can you please take these changes?

@ecki

ecki commented Jun 10, 2026

Copy link
Copy Markdown
Owner

Thanks for the patches, This may take a long time to review

ecki
ecki reviewed Jul 18, 2026
View reviewed changes

@ecki ecki left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine, I am not sure about the explizite breaks, but I am not up to Date with latest Linzers, so if you think they are ok, then keep them, maybe comment all with unreadhable?

I had some questions inline, can you Check, please?

Comment thread netstat.c
Comment thread rarp.c Outdated
Comment thread route.c Outdated
Comment thread slattach.c
Comment thread slattach.c
Comment thread statistics.c
Comment thread statistics.c Outdated
Comment thread lib/hw.c
@sshedi

sshedi commented Jul 18, 2026

Copy link
Copy Markdown
Author

Looks mostly fine, I am not sure about the explizite breaks, but I am not up to Date with latest Linzers, so if you think they are ok, then keep them, maybe comment all with unreadhable?

I had some questions inline, can you Check, please?

Thanks a lot for spending time on this. I have addressed all of them and responded to few. Please check.

@sshedi
sshedi requested a review from ecki July 18, 2026 06:44
@sshedi
Add few more files to gitignore
257f850 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
sshedi added 20 commits July 19, 2026 00:31
@sshedi
arp: fix cppcheck issues and gcc build warnings
8978e2f 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
hostname: fix cppcheck issues and gcc build warnings
8528214 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
ifconfig: fix cppcheck issues and gcc build warnings
e887420 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
iptunnel: fix cppcheck issues and gcc build warnings
946a417 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
ipmaddr: fix cppcheck issues and gcc build warnings
5867e88 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
mii-tool: fix cppcheck issues and gcc build warnings
e86fbe6 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
nameif: fix cppcheck issues and gcc build warnings
0d2338f 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
netstat: fix cppcheck issues and gcc build warnings
2d68926 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
plipconfig: fix cppcheck issues and gcc build warnings
6eb79a7 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
rarp: fix cppcheck issues and gcc build warnings
a140972 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
route: fix cppcheck issues and gcc build warnings
d75e74a 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
slattach: fix cppcheck issues and gcc build warnings
c28c2b2 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
statistics: fix cppcheck issues and gcc build warnings
8a8d5d2 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
lib/arcnet: fix cppcheck issues and gcc build warnings
d4b6e3a 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
lib/ax25: fix cppcheck issues and gcc build warnings
b5e1544 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
lib/ddp_gr: fix cppcheck issues and gcc build warnings
6c89b4a 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
lib/ec_hw: fix cppcheck issues and gcc build warnings
5e09cee 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
lib/ether: fix cppcheck issues and gcc build warnings
9e88a7d 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
lib/fddi: fix cppcheck issues and gcc build warnings
cb8d14d 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
lib/hw: fix cppcheck issues and gcc build warnings
85dd10f 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
sshedi added 9 commits July 19, 2026 00:53
@sshedi
lib/netrom_gr: fix cppcheck issues and gcc build warnings
550e8b8 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
lib/slip: fix cppcheck issues and gcc build warnings
d469276 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
lib/strip: fix cppcheck issues and gcc build warnings
3d59936 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
lib/tr: fix cppcheck issues and gcc build warnings
c3bfd23 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
lib/unix: fix cppcheck issues and gcc build warnings
6d68025 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
lib/util-ank: fix cppcheck issues and gcc build warnings
ac09500 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
lib/x25: fix cppcheck issues and gcc build warnings
93ef539 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
lib/x25_gr: fix cppcheck issues and gcc build warnings
bf9661d 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
@sshedi
Enforce Werror and Wextra to default CFLAGS
7b8870d 
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
ecki
ecki reviewed Jul 18, 2026
View reviewed changes
Comment thread statistics.c
ecki
ecki reviewed Jul 18, 2026
View reviewed changes
Comment thread arp.c
ecki
ecki reviewed Jul 18, 2026
View reviewed changes
Comment thread arp.c
ecki
ecki reviewed Jul 18, 2026
View reviewed changes
Comment thread Makefile Outdated
ecki
ecki reviewed Jul 18, 2026
View reviewed changes
Comment thread netstat.c Outdated
ecki
ecki reviewed Jul 18, 2026
View reviewed changes
Comment thread netstat.c
ecki
ecki reviewed Jul 18, 2026
View reviewed changes
Comment thread netstat.c
ecki
ecki reviewed Jul 18, 2026
View reviewed changes
Comment thread rarp.c
ecki
ecki reviewed Jul 18, 2026
View reviewed changes
Comment thread rarp.c Outdated
ecki
ecki reviewed Jul 18, 2026
View reviewed changes
Comment thread route.c
ecki
ecki reviewed Jul 18, 2026
View reviewed changes
Comment thread statistics.c Outdated
ecki
ecki reviewed Jul 18, 2026
View reviewed changes

@ecki ecki left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for seeing that through, will be great if it Passes Werror!

@sshedi
sshedi force-pushed the sshedi-fixes branch 2 times, most recently from 8d6650b to 7b8870d Compare July 18, 2026 19:52
@sshedi

sshedi commented Jul 24, 2026

Copy link
Copy Markdown
Author

Ping.

@sshedi

sshedi commented Jul 30, 2026

Copy link
Copy Markdown
Author

Hi @ecki , gentle reminder on this.

@sshedi

sshedi commented Aug 6, 2026

Copy link
Copy Markdown
Author

Hi @ecki can you please merge this? Thank you.

@sshedi
sshedi requested a review from ecki August 6, 2026 13:43
@ecki

ecki commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Please dont nag, it’s not a high pro change for me. When all my comments are addressed, I will merge it as soon a if I have the time to Test and Review it.

@sshedi

sshedi commented Aug 6, 2026

Copy link
Copy Markdown
Author

Please dont nag, it’s not a high pro change for me. When all my comments are addressed, I will merge it as soon a if I have the time to Test and Review it.

Thanks for the clarification. I've addressed all of the review comments. I'll leave it with you for testing and final review, and let me know if anything else comes up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ecki ecki Awaiting requested review from ecki
1 more reviewer
@oldeepsmile-beep oldeepsmile-beep oldeepsmile-beep approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sshedi @ecki @oldeepsmile-beep