Derive GCC version flag from resolved toolchain version - #154
Open
nradakovic wants to merge 1 commit into
Open
nradakovic wants to merge 1 commit into
nradakovic wants to merge 1 commit into
Conversation
The `-V<version>,gcc_nto<cpu>` flag passed to qcc for QNX toolchains was hardcoded to `12.2.0` in a static, repo-wide `cc_feature`, so it never reflected a toolchain instance's actual `version`/`gcc_version` attribute or version-matrix entry. - Convert `gcc_version_flags` into a per-instance generated feature (features/custom/qnx/gcc_version_flags/feature.bzl), mirroring the existing `sdp_env` pattern, driven by the resolved `gcc_version` and normalized target CPU. - Wire it into rules/gcc.bzl's get_custom_cc_features_qnx() and reference the per-instance label in make_cc_features.bzl instead of the shared static target. - Add QNX_SDP_TO_GCC_VERSION in rules/common.bzl to default gcc_version from sdp_version's major release, and fail the build if an explicit version conflicts with what the SDP ships.
nradakovic
requested review from
AlexanderLanin and
dcalavrezo-qorix
as code owners
September 29, 2026 12:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-V<version>,gcc_nto<cpu>flag passed to qcc for QNX toolchains was hardcoded to12.2.0in a static, repo-widecc_feature, so it never reflected a toolchain instance's actualversion/gcc_versionattribute or version-matrix entry.gcc_version_flagsinto a per-instance generated feature (features/custom/qnx/gcc_version_flags/feature.bzl), mirroring the existingsdp_envpattern, driven by the resolvedgcc_versionand normalized target CPU.