[plantuml tooling] add guideline on element identifiers - #479
Merged
Merged
Conversation
hoe-jo
requested review from
LittleHuba,
castler,
limdor and
ramceb
as code owners
September 21, 2026 13:20
hoe-jo
force-pushed
the
joho_add_element_identifier
branch
from
September 21, 2026 13:25
b5f2698 to
7846c7f
Compare
LittleHuba
reviewed
Sep 21, 2026
Comment on lines
+341
to
+344
| - **Component relation endpoints prefer the surrounding scope.** Inside | ||
| `package pkg`, an endpoint written as `a.B` binds to `pkg.a.B` when such an | ||
| element exists, and only otherwise to the root-anchored reading. Class | ||
| references do not have this ambiguity. |
Contributor
There was a problem hiding this comment.
Mention that this means the bazel package.
Contributor
Author
There was a problem hiding this comment.
removed, its actually a bug, will be a follow up PR
Comment on lines
+345
to
+347
| - **Cross-diagram hyperlinks (`idmap`) are not yet identifier-based for | ||
| sequence diagrams**, so clickable links from a sequence participant to its | ||
| component may not resolve. |
Contributor
There was a problem hiding this comment.
Also applies for class diagrams
Comment on lines
+366
to
+374
| ### Rule 0 | ||
|
|
||
| **Parser/resolver split.** The parser never derives an identifier. It records | ||
| only alias, display name, and the enclosing scope as written. All identifier | ||
| construction happens in the resolver. The resulting field is | ||
| `LogicComponent.id` for components, `SimpleEntity.id` for classes, and | ||
| `SequenceParticipant.uid` for sequence participants. | ||
|
|
||
| ### Rule A |
Contributor
There was a problem hiding this comment.
Number or letter, but please no mix.
hoe-jo
force-pushed
the
joho_add_element_identifier
branch
from
September 22, 2026 06:37
7846c7f to
a39246d
Compare
LittleHuba
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.