Domain categories - #1585
Conversation
f3ef5b9 to
a0b8cb0
Compare
32a134e to
181b09e
Compare
|
@manourym thank you for the contributions, I will take a look when I have come spare time! |
|
I will request the kit master builder to take a look. I guess the alignment is still not optimal. |
There was a problem hiding this comment.
🟡 Changes recommended
Domain links, sidebar classification, accessibility contrast, and the copyright year remain unresolved.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds domain-based KIT navigation and an Engineering-specific gallery.
Changes:
- Groups navbar and sidebar KITs by domain.
- Adds a filtered Engineering domain page.
- Adds domain styling and gallery configuration options.
File summaries
| File | Review |
|---|---|
utils/generateKitNavItems.js |
Non-Engineering headings incorrectly link to the unfiltered cross-industry page. |
utils/generated/kitNavItems.js |
Regenerates domain-grouped navigation data. |
src/pages/Kits/cross-industry/engineering/index.js |
Adds the Engineering gallery; update the creation year from 2025 to 2026. |
src/css/custom.css |
Light-theme green text has insufficient contrast at lines 552, 565, 585, and 625. |
src/components/2.0/KitGalleryHeader/index.js |
Supports custom title styling. |
src/components/2.0/FilteredKitsGallery/index.js |
Supports locked domain filtering and custom back links. |
sidebarsDocsKits.js |
Move the Model Based KIT category from Simulations to Engineering. |
DEPENDENCIES |
Updates dependency approval references. |
Review details
Suppressed comments (3)
src/css/custom.css:565
- The section-header orange has only 2.08:1 contrast against the light background, and the hover orange remains similarly low; this small text requires 4.5:1. Darken both light-theme states while retaining the underline as an additional hover cue.
color: #faa023 !important;
src/css/custom.css:585
- This 0.65rem sidebar label uses
#afc72don the configured white light background, producing only 1.90:1 contrast instead of the required 4.5:1. Use the darker accessible green for light mode; the existing dark-mode override can stay.
color: #afc72d !important;
src/css/custom.css:626
- The Engineering heading is 3rem, but
#afc72dreaches only 1.90:1 against white (and remains below 3:1 on the near-white header gradient), so even the large-text WCAG threshold is missed. Use a darker light-theme foreground while retaining the brighter dark-mode value.
-webkit-text-fill-color: #afc72d !important;
color: #afc72d !important;
- Files reviewed: 7/8 changed files
- Comments generated: 4
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| type: 'category', | ||
| label: 'Industry Core KIT', | ||
| label: 'Model Based Development and Data Processing KIT', |
| const domainTo = domain === 'Engineering' | ||
| ? '/Kits/cross-industry/engineering' | ||
| : '/Kits/cross-industry'; |
There was a problem hiding this comment.
should be rendered without link, as other domains should create the pages themselves.
| @@ -0,0 +1,53 @@ | |||
| /********************************************************************************* | |||
| * Copyright (c) 2025 Contributors to the Eclipse Foundation | |||
Based on master-kit-builder comments, adapt the color Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Description
This PR introduces domain sections in the main navigation bar as well as in the sidebar view.
Additionally it introduces a domain-specific view page listing the KITs per Domain. Engineering was created as first domain the others still have to be created!
The navigation bar has been adapted, with clickable links to the domain pages: manourym@3b4c53e

The sidebar has been adapted ,so there are now sections included (also clickable links): manourym@3e9b6ba

The Engineering Page has been created as first page (without logo for now): manourym@a0b8cb0
Updates #1584
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: