Repository navigation
Defer activation reparse while parsing and rethrow UI failures - #1666
Merged
Merged
Conversation
Activating the editor while a parse was running started a nested parse that disposed the outer parse's model. The outer parse then failed with a NullPointerException in UndoManager.setRoot, which hid the real error. UndoManager.activate() now waits for the running parse, as the buffer-change refresh already does. ExecutionUtils.runRethrowUI() did not rethrow in the IDE, because SWT hands a syncExec runnable's exception to the display's exception handler, which the workbench uses to log the exception and continue. The exception is now caught in the runnable and rethrown in the caller. Assisted-by: multiple AI agents and layers of automated tooling 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activating the WindowBuilder editor while a parse was running, for example after the open file was rewritten from outside and the editor was reopened, started a nested parse that disposed the outer parse's model. The outer parse then failed in UndoManager.setRoot with a NullPointerException on m_componentsTree, which is the error users saw on the Design page. UndoManager.activate() now waits for the running parse, as the buffer-change refresh already does. The real error stayed hidden because ExecutionUtils.runRethrowUI() never rethrew inside the IDE: SWT hands a syncExec runnable's exception to the display's exception handler, which the workbench uses to log and continue. runRethrowUI() now rethrows the exception in the calling thread, so a failing design refresh is reported as itself instead of as a follow-up NPE.