FDB-618: Add test using fdb-reindex with the same source/sink fdb - #347
Merged
Conversation
caraghbiner
requested review from
andreas-grafberger
and
a balanced review from Copilot
September 3, 2026 14:15
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Fully reviewed with only a minor, non-blocking wording nit.
Pull request overview
Adds regression coverage for same-source/sink fdb-reindex behavior using an EFAS-style FDB layout.
Changes:
- Tests reindexing, retrieval, wiping, and purging.
- Verifies index compaction.
- Registers the FDB-618 regression test.
File summaries
| File | Description |
|---|---|
tests/regressions/FDB-618/schema |
Defines the EFAS-style schema. |
tests/regressions/FDB-618/FDB-618.sh.in |
Implements the regression workflow; has a non-blocking wording nit on lines 66 and 92. |
tests/regressions/FDB-618/config2.yaml |
Configures the separate sink FDB. |
tests/regressions/FDB-618/config.yaml |
Configures the source/shared FDB. |
tests/regressions/FDB-618/CMakeLists.txt |
Defines the test target. |
tests/regressions/CMakeLists.txt |
Registers the regression directory. |
Review details
Suppressed comments (1)
tests/regressions/FDB-618/FDB-618.sh.in:92
- Correct the spelling of “indices.”
# --- confirm that reindexing into the same FDB produces compact indicies ---
- Files reviewed: 6/7 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
caraghbiner
force-pushed
the
feature/FDB-618-floods-reindex
branch
from
September 3, 2026 14:26
098165d to
453d406
Compare
caraghbiner
force-pushed
the
feature/FDB-618-floods-reindex
branch
from
September 3, 2026 14:26
453d406 to
8cb4511
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a test for how various bits of FDB functionality behave when the
fdb-reindextool is used. Somewhat surprisingly, the FDB seems to behave fine: new indexes are created masking the old ones, and purge seems to correctly remove the old ones.Written with the efas use case in mind (FDB-618)
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/fdb/pull-requests/PR-347