DE-3673 Fix levtype for time statistics on snow depth (228141) - #294
Open
cplltr wants to merge 4 commits into
Open
DE-3673 Fix levtype for time statistics on snow depth (228141)#294cplltr wants to merge 4 commits into
cplltr wants to merge 4 commits into
Conversation
…c -> sol The sfc->sol levtype fix in fixMapToSol() covered the instantaneous snow depth (228141) but not its statistically processed variants produced by statistics-mtg2 (average->235078, max->237078, min->238078, stddev->239078). As a result the monthly-averaged snow depth kept the wrong levtype and did not encode/archive. Add the four time-processed params to the rule.
Contributor
Author
|
Targetting hotfix/2.10.3 because it is the multio version currently used in the 49r3 bundle in ifs-raps |
Contributor
Author
|
Addresses this raised issue: #293 |
cplltr
changed the title
Contributor
Author
|
This should merge cleanly into develop. Also now covers 238038 and 238 -- which are not needed in production, but can be useful for research, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The climate DT portfolio required for CY49R3 includes snow depth water equivalent, both instantaneous (228141) and time-averaged (235078). These parameters should be encoded as both levtype=sfc (vertical sum) and levtype=sol (per-level, five layers for snow variables). The branch used by 49r3 climate DT has a sfc->sol mapping for paramid 228141 (instantaneous), but not for 235078 (its time-averaged version).
JIRA: https://jira.ecmwf.int/browse/DE-3673
Description
The sfc->sol levtype fix in fixMapToSol() covered the instantaneous snow
depth (228141) but not its statistically processed variants produced by
statistics-mtg2 (average->235078, max->237078, min->238078, stddev->239078).
As a result the monthly-averaged snow depth kept the wrong levtype and did
not encode/archive. Add the four time-processed params to the rule.
Contributor Declaration
By opening this pull request, I affirm the following: