개선(deps): Bump sharp from 0.35.3 to 0.35.4 - #155
Merged
Merged
Conversation
dependabot
Bot
added
the
dependencies
Contributor
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Owner
|
@dependabot rebase |
Bumps [sharp](https://github.com/lovell/sharp) from 0.35.3 to 0.35.4. - [Release notes](https://github.com/lovell/sharp/releases) - [Commits](lovell/sharp@v0.35.3...v0.35.4) --- updated-dependencies: - dependency-name: sharp dependency-version: 0.35.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/sharp-0.35.4
branch
from
September 22, 2026 07:10
6c6f941 to
65faa26
Compare
eddmpython
added a commit
that referenced
this pull request
Sep 22, 2026
증상 - Dependabot 경보가 머지 뒤에도 열려 있었다. 루트 lock: sharp 0.35.3(#68 high, libheif), adm-zip 0.6.0(#75 high 메모리 할당, #61 medium 심볼릭 링크 추출). pushHub lock: sharp 0.35.3(#69 high). - #154(transformers 4.3.0 + adm-zip 0.6.1 을 표방)와 #155(sharp 0.35.4)를 머지했는데도 master 의 lock 은 adm-zip 0.6.0, sharp 0.35.3 이었다. 원인 - 루트 package.json 의 overrides 가 sharp 와 adm-zip 을 정확 버전으로 고정한다. Dependabot 은 override 를 올리지 못하므로 #154 는 transformers 만 올렸다(adm-zip 은 override 0.6.0 에 묶임). - #155 는 rebase 뒤 override 값만 0.35.4 로 바꾸고 lock 은 0.35.3 그대로였다. transformers 4.3.0 이 sharp ^0.35.4 를 요구하는데도 npm ci 가 이 불일치를 거부하지 않아 Deploy Landing 은 통과했고, 실제 설치는 취약 버전이었다. - infra/workers/pushHub/package.json 도 자체 override 로 sharp 0.35.3 을 고정한다. 변경 - package.json overrides: adm-zip 0.6.0 -> 0.6.1 (sharp 는 #155 가 이미 0.35.4). - infra/workers/pushHub/package.json overrides: sharp 0.35.3 -> 0.35.4. - 두 lock 은 npm install --package-lock-only 뒤 npm update sharp adm-zip --package-lock-only 로 재생성했다. override 값만 바꾸면 npm 이 이미 잠긴 항목을 다시 해석하지 않아 update 가 필요했다. - 버전 변화는 sharp·@img/sharp-*·@img/sharp-libvips-*(0.35.4/1.3.3), @emnapi/runtime 1.11.3, adm-zip 0.6.1 뿐이다. 루트 lock 의 나머지 텍스트 차이는 #148 lock 에 빠져 있던 "dev": true 표기를 npm 이 정규화한 것이다. 검증 (origin/master c717a4c 기준 별도 worktree) - 루트 npm ci 성공, 설치 버전 sharp 0.35.4 / adm-zip 0.6.1 / vitest 5.0.1. - landing check 통과, landing test 22 파일 186 개 통과, landing build 성공. - @dartlab/ui-runtime test 17 파일 105 개 통과. - pushHub npm ci 성공, 설치 sharp 0.35.4, test 2 파일 24 개 통과. 남은 것 - vitest 계열 경보(#62 #64 #65 #66)는 #148(vitest 5) 머지로 lock 상 해소됐다. 경보는 GitHub 재스캔 뒤 닫힌다. - Dependabot 이 override 대상 취약점을 스스로 닫지 못하는 구조는 그대로다. 다음 경보도 같은 절차(override 수동 상향, lock 재생성, npm ci 확인)가 필요하다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps sharp from 0.35.3 to 0.35.4.
Release notes
Sourced from sharp's releases.
Commits
7f1a0a2Release v0.35.4f927818Upgrade to sharp-libvips v1.3.3e802092Prerelease v0.35.4-rc.0e13eb2fCI: Fix wasm32 build (#4589)a82a0b3Upgrade to libvips v8.18.68044fe4Bound resize dimensions to coordinate limit147f859Docs: changelog entries for #4578 #4584ee5bfb8Tests: use yauzl directly rather than via extract-zip wrapper7a77889Bump uraimo/run-on-arch-action from 3.1.0 to 3.2.0 (#4588)ea5bef2Improve support for input Streams finishing before output is requested (#4584)