Skip to content

feat: remove change_enterprise_user_username management command - #277

Merged
marlonkeating merged 1 commit into
release-ulmofrom
mkeating/ENT-11572
May 11, 2026
Merged

marlonkeating merged 1 commit into
release-ulmofrom
mkeating/ENT-11572

Conversation

@marlonkeating

@marlonkeating marlonkeating commented May 11, 2026

Copy link
Copy Markdown

Note: This description is divorced from the actual code changes due to a mistake during cherry-picking.


Cherry pick from openedx#38108

Jira Ticket

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

Copilot AI review requested due to automatic review settings May 11, 2026 16:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is described as a cherry-pick to “replace enterprise username import in progress/views.py with pluggable_override”, but the changes shown here only remove the change_enterprise_user_username Django management command and its associated tests under common/djangoapps/student/management/.

Changes:

  • Removed the change_enterprise_user_username management command.
  • Removed the corresponding unit tests for that command.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
common/djangoapps/student/management/commands/change_enterprise_user_username.py Deleted the enterprise-username change management command.
common/djangoapps/student/management/tests/test_change_enterprise_user_username.py Deleted the tests covering the removed management command.
Comments suppressed due to low confidence (1)

common/djangoapps/student/management/commands/change_enterprise_user_username.py:1

  • PR title/description indicate a change to enterprise username handling in progress/views.py via pluggable_override, but this diff only deletes the change_enterprise_user_username management command (and its tests). If the deletions are intentional, please update the PR title/description to match; if not, it looks like the intended cherry-pick content is missing from this backport branch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pwnage101 pwnage101 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved conditional on renaming the commit to "feat: remove change_enterprise_user_username management command".

git commit --amend -m 'feat: remove change_enterprise_user_username management command'

@marlonkeating
marlonkeating merged commit 0a9329d into release-ulmo May 11, 2026
64 checks passed
@marlonkeating
marlonkeating deleted the mkeating/ENT-11572 branch May 11, 2026 20:36
@pwnage101 pwnage101 changed the title feat: replace enterprise username import in progress/views.py with pluggable_override feat: remove change_enterprise_user_username management command Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants