feat: remove change_enterprise_user_username management command - #277
Conversation
There was a problem hiding this comment.
Pull request overview
This PR is described as a cherry-pick to “replace enterprise username import in progress/views.py with pluggable_override”, but the changes shown here only remove the change_enterprise_user_username Django management command and its associated tests under common/djangoapps/student/management/.
Changes:
- Removed the
change_enterprise_user_usernamemanagement command. - Removed the corresponding unit tests for that command.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| common/djangoapps/student/management/commands/change_enterprise_user_username.py | Deleted the enterprise-username change management command. |
| common/djangoapps/student/management/tests/test_change_enterprise_user_username.py | Deleted the tests covering the removed management command. |
Comments suppressed due to low confidence (1)
common/djangoapps/student/management/commands/change_enterprise_user_username.py:1
- PR title/description indicate a change to enterprise username handling in progress/views.py via pluggable_override, but this diff only deletes the
change_enterprise_user_usernamemanagement command (and its tests). If the deletions are intentional, please update the PR title/description to match; if not, it looks like the intended cherry-pick content is missing from this backport branch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pwnage101
left a comment
There was a problem hiding this comment.
Approved conditional on renaming the commit to "feat: remove change_enterprise_user_username management command".
git commit --amend -m 'feat: remove change_enterprise_user_username management command'
632c206 to
8574a81
Compare
Note: This description is divorced from the actual code changes due to a mistake during cherry-picking.
Cherry pick from openedx#38108
Jira Ticket
Description
Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.
Useful information to include:
"Developer", and "Operator".
changes.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.