Repository navigation
Analytics: Allow or Decline at launch, sync needs Allow - #5
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 210adfc05b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e path Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…d, not even locally) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps (PWA, iOS, Android). A normal startup popup, Allow or Decline.
analyticsConsentflag), so the popup does not come back.app_openper launch and a newapp_hiddenwithengaged_s(seconds in the app). Every event carriesconsent: granted|denied(register it in GA4 as an event-scoped custom dimension).FirebaseAnalytics.setConsent, andInfo.plist/AndroidManifest.xmldefault every analytics consent type to denied so the SDK starts anonymous before JS runs. No change to storage or SQLite.Verified in a browser (web): the popup opens at launch; Decline leaves no cookies and no stored choice, data is saved to
localStorageregardless, and the popup returns on the next launch; tapping sync without Allow opens the popup with the sync line, Decline does nothing, Allow stores the choice, sets the cookies and continues into sign-in; after Allow the popup does not return and the data is intact.svelte-checkclean. (The browser pane here never fires a dialog'scloseevent, so I dispatched it by hand to emulate real browsers.)Needs a device: that the native SDK really starts anonymous (TestFlight / Android + GA4 DebugView), and the new
GOOGLE_ANALYTICS_DEFAULT_ALLOW_*/google_analytics_default_allow_*keys. Also the App Privacy answers in App Store Connect.🤖 Generated with Claude Code