Skip to content

Consent: asking for sync counts as the session's offer - #8

Merged
dukobpa3 merged 1 commit into
mainfrom
consent-offer-after-sync
Oct 22, 2026
Merged

dukobpa3 merged 1 commit into
mainfrom
consent-offer-after-sync

Conversation

@dukobpa3

Copy link
Copy Markdown
Member

Same fix as the review comment on eggs-gd/i-ching#8, for the journal: if the user taps sync and declines the statistics popup, saving the first entry in the same session no longer opens the popup again. askFor() now marks the session as offered; further explicit sync taps still ask.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-22T09:53:55.548204Z ed601d2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dukobpa3
dukobpa3 merged commit a69121b into main Oct 22, 2026
1 check passed
@dukobpa3
dukobpa3 deleted the consent-offer-after-sync branch October 22, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant