Repository navigation
fix(optiflow): validate saved read-only receipts - #84
Merged
Merged
Conversation
Require complete contract shape and correlated native artifact evidence before accepting saved receipts. Add shared Rust/schema regressions and focused validation evidence for #81.
Pull Request Summary by devActivityMetricsAchievements
|
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A saved
completeOptiflow receipt could reopen successfully with empty artifact lists and a null plan digest. The loader now shares a bounded contract gate with persistence and requires explicit plan proof, required nullable keys, closed paths, exact capabilities, valid digests and coherent states. Reopening correlates the hash-verified native run/report/plan and artifact-set bytes with the recorded IDs, source root and member paths.The shared corpus has 84 cases: 12 accepted controls, 41 schema-invalid cases and 31 further runtime-invalid cases. Replaying it against base
c673654fb7ad86569d3bb32f1412f5eb2fbf2bf3reproduces 45 incorrect acceptances, including all five audit counterexamples and all nine omitted required nullable keys. The existing 25-contract manifest stays unchanged; the repository-validator job explicitly runs the independent Draft 2020-12 receipt check.Validation on Linux x86-64 / Rust 1.85.0:
Handoff · Commands, file/log hashes, provider identity and limitations
These are focused local results. The previously observed full-wrapper timeout and moving-stable Clippy failures in unchanged code remain under #34. No hosted CI was dispatched or polled for this checkpoint, no full-suite/macOS/Windows qualification is claimed, and no timeout or lint policy was weakened. Local records remain editable evidence without signature or mutation authority. Broader continuation-documentation reconciliation remains #82.
Closes #81.