Skip to content

Restore the locked Rust qualification baseline #458

Open

Description

@szmyty

Merged implementation checkpoint — October 27, 2026

PR #462 merged at 8d7a71edd4033a60801c663fec242a2195a2562e with maintainer authorization. The two schema integer fixes and Snap workspace selection are merged. Cargo-produced lock reconciliation, recorded lint findings and exact-source executable qualification remain deferred. #458 remains open; no green baseline or package support is claimed.

Tests, builds/compiler checks, lint/format/schema/documentation tooling, native/provider/CLI execution and CI remain unrun under the maintained sprint deferral. No Actions were dispatched or polled. Earlier draft-state notes below are historical; original scope and acceptance criteria are preserved.


Draft source checkpoint — October 26, 2026

Draft PR #462, head df63e289ba784628dd2897f8f74dbf457fcb22a0, replaces the two inferred overflowing schema literals with u32::MAX (same JSON maximum 4294967295) and selects crates/renderflow-cli in the unpublished Snap template. The package install already targets bin/renderflow, so the obsolete relocation is removed.

Source review and primary Snapcraft/Craft Parts/Cargo documentation support the edits; published blobs/tree match the reviewed local snapshot. No lockfile/dependency/workflow gate/schema range changes. Tests/build/lint/schema/Cargo resolution/package/native/CLI/CI remain unrun; no Actions dispatched or polled.

This does not establish a green baseline or published Snap. #458 remains open for Cargo-produced lock reconciliation, recorded lint findings and exact-source qualification. Handoff. Original scope and acceptance criteria follow unchanged.


Problem and evidence

At main 81088f01b14c010e7dc6523763771f8461ed9b09, existing hosted results already identify concrete blockers to #419's exact-commit green qualification gate:

  • spec.rs:2363 and spec.rs:2408 contain 4294967295 JSON numeric literals that the recorded Rust 1.94 build infers as overflowing i32 literals. The installer job stops during binary compilation, before installer smoke execution.
  • The build-and-test job stops at Clippy with those compiler errors and 22 lint errors under -D warnings; later build/test steps are not evidence of executed tests.
  • The maximal corpus job exits before tests because Cargo.lock would need an update under --locked. Its exact resolution delta remains unverified; do not regenerate it from metadata by hand or guess a culprit.
  • The optional Snap recipe uses the Rust plugin at a virtual-workspace root without a selected install package. Its recorded job reports the virtual-manifest install error as well as the shared compiler errors. Snap remains an unpublished template; this is not evidence of a broken published Snap channel.

Existing evidence:

Scope

Author the smallest compiler/schema, meaningful lint, workspace package-selection and lock-resolution corrections. Preserve schema numeric maxima and public contract meaning. Investigate the lock delta using Cargo when qualification resumes and retain a reviewable explanation. Keep -D warnings, --locked, installer verification, required workflow gates and honest package support status.

This is the focused current-baseline follow-up to #419 and the deferred qualification noted in #406/#429/#430. Closed #407 concerns a different September baseline and must remain closed.

Acceptance criteria

  • Source corrections preserve the intended unsigned stream-index range and schema semantics; no global lint suppression or weakened gate is used to obtain green results.
  • A reviewed Cargo-produced lock update matches the actual manifests and intended pinned versions; any unexpected dependency movement is explained.
  • The Snap template selects the correct workspace CLI package or uses an explicitly documented equivalent build/install path; no Snap Store availability claim is added.
  • After the maintainer resumes qualification, run the repository's Rust 1.94/MSRV, locked build/test/Clippy, locked corpus and affected installer/package checks against the exact reviewed source; retain failure, skip and success separately. The precise gate commands remain governed by the checked-in workflows and [Release] Publish the first verified Renderflow integration-candidate release and reconcile distribution truth #419.
  • Reconcile the exact-source result in [Release] Publish the first verified Renderflow integration-candidate release and reconcile distribution truth #419 and the roadmap without closing creative/composition acceptance criteria that those checks do not prove.

Dependencies and boundaries

Full completion still requires the maintained executable-qualification deferral to resume; this common pause is not an additional upstream dependency. Source review and preparation may start first. This issue does not authorize tests, compiler/build, product formatting/linting, schema validators, native/provider/CLI execution, installs or CI dispatch now. It does not implement #419's publication or qualify all optional creative providers.

Audit evidence: https://github.com/egohygiene/renderflow/blob/audit/flow-suite-20261021T025401Z/audits/flow-suite-20261021T025401Z.md
Roadmap: #367

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions