Skip to content

fix(ble_elm327): fix compile errors and implement flow control waitin… #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eigger merged 1 commit into from
Jul 13, 2026
Merged

fix(ble_elm327): fix compile errors and implement flow control waitin… #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions components/ble_elm327/ble_elm327.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,15 @@ void BleElm327Component::add_init_command(const std::string &cmd) {
void BleElm327Component::loop() {
if (elm_state_ == ElmState::IDLE) return;

if (waiting_for_response_) {
if (millis() - last_tx_time_ > 5000) {
ESP_LOGW(TAG, "Timeout waiting for response to command: %s", last_sent_command_.c_str());
waiting_for_response_ = false;
} else {
return;
}
}

// Drain queued command (init or sensor) with tx_delay
if (!tx_queue_.empty()) {
if (millis() - last_tx_time_ < tx_delay_ms_) return;
Expand Down Expand Up @@ -124,12 +133,9 @@ void BleElm327Component::loop() {
void BleElm327Component::dump_config() {
ESP_LOGCONFIG(TAG, "BLE ELM327:");
ESP_LOGCONFIG(TAG, " MAC address : %s", this->parent_->address_str());
char service_uuid_str[esphome::esp32_ble::UUID_STR_LEN] = {0};
char rx_char_uuid_str[esphome::esp32_ble::UUID_STR_LEN] = {0};
char tx_char_uuid_str[esphome::esp32_ble::UUID_STR_LEN] = {0};
ESP_LOGCONFIG(TAG, " Service UUID : %s", service_uuid_.to_str(service_uuid_str));
ESP_LOGCONFIG(TAG, " RX Char UUID : %s", rx_char_uuid_.to_str(rx_char_uuid_str));
ESP_LOGCONFIG(TAG, " TX Char UUID : %s", tx_char_uuid_.to_str(tx_char_uuid_str));
ESP_LOGCONFIG(TAG, " Service UUID : %s", service_uuid_.to_string().c_str());
ESP_LOGCONFIG(TAG, " RX Char UUID : %s", rx_char_uuid_.to_string().c_str());
ESP_LOGCONFIG(TAG, " TX Char UUID : %s", tx_char_uuid_.to_string().c_str());
ESP_LOGCONFIG(TAG, " TX delay : %ums", tx_delay_ms_);
ESP_LOGCONFIG(TAG, " Base init commands : ATZ, ATE0, ATL0, ATS0, ATH0, ATSP0");
ESP_LOGCONFIG(TAG, " Extra init commands: %u", (unsigned)extra_init_commands_.size());
Expand Down Expand Up @@ -161,6 +167,7 @@ void BleElm327Component::gattc_event_handler(esp_gattc_cb_event_t event, esp_gat
current_pre_commands_.clear();
rx_buffer_.clear();
last_sent_command_.clear();
waiting_for_response_ = false;
ESP_LOGW(TAG, "Disconnected from ELM327");
break;

Expand All @@ -186,6 +193,7 @@ void BleElm327Component::gattc_event_handler(esp_gattc_cb_event_t event, esp_gat
}
last_tx_time_ = millis();
elm_state_ = ElmState::CONNECTED;
waiting_for_response_ = false;
for (const char *cmd : BASE_INIT_COMMANDS) {
std::string framed = std::string(cmd) + "\r";
tx_queue_.push({framed, nullptr});
Expand Down Expand Up @@ -219,6 +227,7 @@ bool BleElm327Component::send_command(const std::string &cmd) {
ESP_GATT_WRITE_TYPE_NO_RSP);
ESP_LOGD(TAG, ">> %s", cmd.c_str());
last_sent_command_ = normalize_command(cmd);
waiting_for_response_ = true;
return true;
}

Expand All @@ -228,6 +237,7 @@ void BleElm327Component::on_notify(const uint8_t *data, uint16_t length) {
while ((pos = rx_buffer_.find('>')) != std::string::npos) {
std::string response = rx_buffer_.substr(0, pos);
rx_buffer_.erase(0, pos + 1);
waiting_for_response_ = false;
process_response(response);
}
}
Expand Down
1 change: 1 addition & 0 deletions components/ble_elm327/ble_elm327.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ class BleElm327Component : public Component, public ble_client::BLEClientNode {

std::string rx_buffer_;
std::string last_sent_command_;
bool waiting_for_response_{false};
};

} // namespace ble_elm327
Expand Down