Repository navigation
Keep Dependabot away from the MSRV toolchain pin - #4
Merged
Merged
Conversation
The MSRV job pins `dtolnay/rust-toolchain@1.88` because that is the oldest Rust this crate claims to build on. Dependabot reads the ref as a version and opened #3, "Bump dtolnay/rust-toolchain from 1.88 to 1.100" — sorting 88 to 100, which is not a Rust that exists. CI failed with "could not download nonexistent rust version 1.100.0". The failure is the harmless outcome. A bump that resolved would leave the job named "MSRV (1.88)" while compiling against something newer, and the manifest field it exists to enforce would quietly stop being enforced — the exact drift the job was added to catch. The other two uses of this action are `@stable`, which Dependabot does not treat as a version, so ignoring the action outright costs nothing. The pin moves when `rust-version` moves, by hand, in the same commit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3.
The MSRV job pins
dtolnay/rust-toolchain@1.88because that is the oldest Rust this crate claims to build on. Dependabot reads that ref as a version and proposed bumping it to1.100— sorting 88 to 100. CI failed with:The failure is the harmless outcome. A bump that resolved would be worse: the job would keep the name
MSRV (1.88)while compiling against something newer, andrust-versioninCargo.tomlwould quietly stop being enforced — the exact drift the job was added to catch.The other two uses of this action are
@stable, which Dependabot does not treat as a version, so ignoring the action outright costs nothing. The pin moves whenrust-versionmoves, by hand, in the same commit.🤖 Generated with Claude Code