Repository navigation
Conversation
bitpshr
force-pushed
the
paul/cli-platform-user-agent
branch
from
October 22, 2026 01:52
a9653ae to
fd399e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From the API's side today, a CLI request is just
elevenlabs-cli/<version> cmd/<command>, so a problem like the Windows sign-in misses in #167 can't be told apart from WSL, containers or SSH. The hand-written commands now appendos/<windows|macos|linux|other>, plusenv/<ssh|container|wsl>when one applies, after theircmd/tag. Only whether the relevant environment variables are set is checked, and their values are never sent.onboardalso passescli_osandcli_envon the approval-page link. A sign-in whose callback never reaches the CLI makes no API call, so the page's events are the only place those misses can be counted per platform. Container detection moves fromonboard/browser.rsto a smallworkflow/platform.rs, and the browser check behaves exactly as before.Stacked on #167, which changes the same sign-in code. The xi side, which reads the tags on the backend and the link parameters on the approval page, is a separate PR. With no version bump, this ships with the next release.
Testing
cargo test: the platform detection tests and thecommand_scopetests pass, and so do the onboard integration tests. The Windows code type-checks forx86_64-pc-windows-msvc.