Translate nested resources under a parent with options - #18
Merged
kipcole9 merged 1 commit intoSep 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
Problem
localize/2matches a parent only when it has no options.only:orexcept:, the child path is not translated, while the same block without options works.After
Details
Localize.Routes.localize/2has a clause forresources path, controller do ... endbut none forresources path, controller, options do ... end. That shape fell through to the plain verb clause, which translates only the parent path.localize_nested_resources/2.scopeis not in the localizable verbs, so there is no matching gap forscopewith options.Nested resources a parent with options translates the nested pathintest/routes_test.exs, which fails onmain.mix test(268 passed),mix compile --warnings-as-errors,mix format --check-formatted,mix credo --strict(only the existingSigil_q.InterpolationTestname note).AI disclosure: AI models helped us find this issue, write the change, and review it.