Conversation
Contributor
|
@tschuehly - could you please sign the commit? Which release would you like to target? thanks Could you please also comment on: Not required as well? looping @azanux, @alexheifetz |
igordayen
self-requested a review
September 25, 2026 18:41
The LM Studio autoconfigure jar carried its own models/openai-models.yml, copied in #1092 and never updated. When it sorts first on the classpath it shadows the OpenAI catalog, so newer OpenAI models such as gpt-5.4 are missing from the model list. Nothing in the LM Studio module reads the file. Fixes #2064 Signed-off-by: tschuehly <tschuehly@outlook.com>
tschuehly
force-pushed
the
fix/lmstudio-stale-openai-catalog
branch
from
September 26, 2026 07:05
267142c to
1d2e89e
Compare
Author
|
Thanks @igordayen!
|
|
Contributor
|
@tschuehly - assigned milestone 1.5.3 as requested, thanks |
igordayen
approved these changes
Sep 26, 2026
igordayen
left a comment
igordayen
left a comment
Contributor
There was a problem hiding this comment.
@tschuehly looks good, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2064.
Why:
embabel-agent-lmstudio-autoconfigureshipped its ownmodels/openai-models.yml, a copy from #1092 that was never updated. When the LM Studio jar comes first on the classpath, that copy shadows the real OpenAI catalog, and newer OpenAI models (e.g.gpt-5.4,gpt-5.4-mini) are missing from the model list.Change: delete the stale file. Nothing in the LM Studio module reads it.
Test:
LmStudioCatalogTestasserts the LM Studio module ships nomodels/openai-models.yml. It failed before the deletion and passes after; the module's tests pass (14, 0 failures).