Repository navigation
Retell/base - #379
Closed
ddas-rt wants to merge 5 commits into
Closed
Retell/base#379ddas-rt wants to merge 5 commits into
ddas-rt wants to merge 5 commits into
Conversation
* dialog_client: clone ACK per 2xx retransmission (fix PrependHeader panic) WriteAck cloned the ACK once and re-sent that SAME *sip.Request on every 200 OK retransmission. Each resend runs WriteRequest -> ClientRequestAddVia -> Request.PrependHeader, mutating the request header slice in place. Concurrent retransmission handlers (one per retransmitted 2xx, each on its own goroutine) then race -> panic "index out of range" in sipgo's transaction-layer goroutine (uncatchable by callers) -> process crash. It also accumulated a duplicate Via. Send a fresh clone of an immutable snapshot per retransmission instead. TestDialogClientACKRetransmissionOverlap fires overlapping retransmissions and asserts one Via per ACK; it fails under -race on the old shared request and passes with the fix. The old sequential TestDialogClientACKRetransmission cannot catch this (one reply at a time, only counts ACKs). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * dialog_client: complete module rename (fix mixed emiago/RetellAI imports) dialog_client.go kept github.com/emiago/sipgo imports while the rest of the module was renamed to github.com/RetellAI/sipgo, so the module mixed two paths and did not compile. Rename its imports too. The ACK-retransmission fix + overlap test are unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
* Fix ACK retransmissions bypassing the dialog route set * Restore existing ACK comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.