feat(cli): thread Config through the cache-sync path - #196
Open
ecalifornica wants to merge 1 commit into
Open
Conversation
|
🔍 Preview deployed: https://b66400a6.toolpath.pages.dev |
ecalifornica
force-pushed
the
robert/config-sync
branch
from
August 14, 2026 19:49
d6573f9 to
bf98951
Compare
akesling
reviewed
Aug 17, 2026
| observer: &mut dyn SyncObserver, | ||
| ) -> Result<Vec<(ArtifactType, SyncOutcome)>> { | ||
| let manifest = load_manifest()?; | ||
| let manifest = load_manifest(config)?; |
Contributor
There was a problem hiding this comment.
Would it make sense to, instead of plumbing the whole config, splitting the parts out that are specific earlier in this call chain? "load_manifest" doesn't really need all of the values in the overall Config, does it?
Collaborator
Author
There was a problem hiding this comment.
Done in the updated diff: the engine takes config_dir: &Path, resolved once at the command layer. Open question in the PR body: a ConfigDir newtype instead of the bare &Path.
ecalifornica
force-pushed
the
robert/config-sync
branch
from
August 17, 2026 19:38
bf98951 to
23c9896
Compare
ecalifornica
force-pushed
the
robert/config-sync
branch
from
August 17, 2026 20:03
23c9896 to
fe47a7e
Compare
akesling
approved these changes
Aug 17, 2026
cmd_cache and cmd_query resolve the config directory once and build the HarnessBundle through providers::harness_bundle. The manifest layer takes config_dir; manifest_path is infallible. The transitional record surfaces load Config and resolve the directory per call.
ecalifornica
force-pushed
the
robert/config-sync
branch
from
August 18, 2026 20:07
fe47a7e to
c5d811c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #184. Stacked on #195. path-cli only.
Why
&Config. The sync engine takes the config directory, the one value it uses. The missing-directory error surfaces at command entry instead of inside sync.providers::harness_bundle(config)builds the sync providers, so construction stays inproviders.Open question
config_dir: &Pathto aConfigDirnewtype? The document-cache PR later in the stack needs the same directory and would take the same type.