fix: use semicolon by default for meter-reading CSV - #3
Merged
Merged
Conversation
Align omitted CSV delimiters with the backend default. Callers that need comma-separated output must select CsvDelimiter.COMMA explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meter-reading CSV exports without an explicit delimiter now use
semicolon, matching the backend's existing default. Previously, the client explicitly sentcomma.Explicit comma, semicolon and tab remain supported. Callers that require the previous output must pass
delimiter: CsvDelimiter.COMMA. Document the new default in the public type and usage example.Import the updated shared contracts from energy-tracker/api-client-python#6, pinned to commit
54ff998357ffa7c191f4538b5b3c49308b777d49with updated checksums. Tests cover default semicolon output and explicit comma/tab selections alongside the existing semicolon case.Validation:
npm run checkpasses with 158 tests, 99.67% line coverage, formatting, type checking, build, npm package installation, CJS/ESM imports and TypeScript 5.8/7 consumers. No version bump, tag or publication.