Repository navigation
Conversation
Owner
Author
|
CI failure is due to dependency resolution, not failing PHPUnit assertions. psalm/plugin-phpunit 0.20.4 requires psalm/psalm-plugin-api ^0.1|^0.2|^0.3, and those API packages conflict with Psalm <7, while this template currently pins Psalm ^6.16. I am closing this experimental PR rather than upgrading the template's Psalm major version just to remove one narrow suppression. Keep the existing suppression for now; revisit the plugin if/when the template intentionally upgrades to Psalm 7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed: CI showed psalm/plugin-phpunit 0.20.4 is incompatible with this template's Psalm ^6.16 constraint because its plugin API dependency conflicts with Psalm versions below 7. Keep the narrow existing suppression rather than introducing a major Psalm upgrade solely for this cleanup.