Repository navigation
[pull] main from hookdeck:main - #192
Merged
Merged
Conversation
* fix: include credentials in publisher cache key Rotating a destination's credentials (e.g. webhook rotate_secret) had no effect while the destination's publisher was cached, because MakePublisherKey only hashed ID, type and config. Include credentials in the key so a credential change resolves a fresh publisher. Hash map entries in sorted key order so the key is stable across calls. Fixes #1084 * Fold delivery metadata into publisher key; harden eviction log (review) - Include dest.DeliveryMetadata in MakePublisherKey: providers bake delivery metadata into the publisher at creation, so changing delivery_metadata had the same stale-publisher bug as credentials. Add a 'delivery metadata change' subtest (RED without the change: both events hit the pre-change publisher). - onEvict: log only the destination ID prefix, not the full cache key. The key now folds credentials and delivery metadata into an FNV hash, so the suffix is a secret-derived value that should not reach logs. - hashSortedMap: use slices.Sorted(maps.Keys(m)) per review nit.
…est logs (#1095) * fix(apirouter): omit credentials from include=destination on attempts Attempts embed the destination without credentials. Credentials are only returned by the destination endpoints. The spec gets an AttemptDestination schema, since the per-type Destination schemas require credentials. Refs #1094 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(apirouter): redact all credential values from logged request bodies Redaction relied on provider metadata, which skipped credentials not marked sensitive (webhook secrets) and bodies without a type (PATCH). Every credential value is now redacted. Refs #1094 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )