Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/egressobs-v2-audio-only.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"github.com/livekit/protocol": patch
---

`egressobs.GetAudioOnly` reports v2 `StartEgress` and replay export requests as audio-only when their Template or Web source sets `audio_only`.
8 changes: 8 additions & 0 deletions observability/egressobs/egress.go
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,15 @@ func GetAudioOnly(info *livekit.EgressInfo) bool {
return req.RoomComposite.AudioOnly
case *livekit.EgressInfo_Web:
return req.Web.AudioOnly
case *livekit.EgressInfo_Egress:
return getAudioOnlyV2(req.Egress)
case *livekit.EgressInfo_Replay:
return getAudioOnlyV2(req.Replay)
default:
return false
}
}

func getAudioOnlyV2(r egress.EgressRequest) bool {
return r.GetTemplate().GetAudioOnly() || r.GetWeb().GetAudioOnly()
}
65 changes: 65 additions & 0 deletions observability/egressobs/egress_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,71 @@ func TestGetAudioOnly(t *testing.T) {
},
audioOnly: true,
},
{
name: "v2 Template audio only",
info: &livekit.EgressInfo{
Request: &livekit.EgressInfo_Egress{
Egress: &livekit.StartEgressRequest{
Source: &livekit.StartEgressRequest_Template{
Template: &livekit.TemplateSource{AudioOnly: true},
},
},
},
},
audioOnly: true,
},
{
name: "v2 Template not audio only",
info: &livekit.EgressInfo{
Request: &livekit.EgressInfo_Egress{
Egress: &livekit.StartEgressRequest{
Source: &livekit.StartEgressRequest_Template{
Template: &livekit.TemplateSource{Layout: "grid"},
},
},
},
},
audioOnly: false,
},
{
name: "v2 Web audio only",
info: &livekit.EgressInfo{
Request: &livekit.EgressInfo_Egress{
Egress: &livekit.StartEgressRequest{
Source: &livekit.StartEgressRequest_Web{
Web: &livekit.WebSource{AudioOnly: true},
},
},
},
},
audioOnly: true,
},
{
name: "v2 Media returns false",
info: &livekit.EgressInfo{
Request: &livekit.EgressInfo_Egress{
Egress: &livekit.StartEgressRequest{
Source: &livekit.StartEgressRequest_Media{
Media: &livekit.MediaSource{},
},
},
},
},
audioOnly: false,
},
{
name: "Replay Template audio only",
info: &livekit.EgressInfo{
Request: &livekit.EgressInfo_Replay{
Replay: &livekit.ExportReplayRequest{
Source: &livekit.ExportReplayRequest_Template{
Template: &livekit.TemplateSource{AudioOnly: true},
},
},
},
},
audioOnly: true,
},
{
name: "Track request returns false",
info: &livekit.EgressInfo{
Expand Down
Loading