Conversation
- DALib/README.md had drifted badly from the root one it duplicated, still advertising .NET 8 and a feature list years out of date, and it is the file nuget.org renders. Point PackageReadmeFile at the root and delete the copy so there is only one to maintain. Co-Authored-By: Imbas <imbas@eris.co>
…ing on Hangul Two defects in Graphics.GetGlyphIndex, both reached through RenderText. The shipped han*.fnt face holds the 2,350 Wansung syllables at glyphs 0-2349 and the 51 Jamo at 2350-2400. The mapping had the blocks the other way round, so every syllable was drawn 51 glyphs late (한 is glyph 2210 and came from 2261), and nothing threw, because the wrong mapping covers the same 2,401 indexes. The indexes were read off the retail face by rendering it. Before that could matter, Encoding.GetEncoding(949) threw NotSupportedException for any Korean character unless the host had registered the code-pages provider. It now asks CodePagesEncodingProvider.Instance directly, as MetaFile already does. RenderTextKoreanTests renders through a synthetic 2,401-glyph face in which every glyph draws its own index, and reads the index back from the pixels. Without either fix all five cases fail: first with the exception, then 51 or 2,350 glyphs off. dalib-ts carries the same order fix in its 3.2.0 release. Co-Authored-By: Imbas <imbas@eris.co>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
han*.fntholds the 2,350 syllables at 0–2349 and the 51 jamo at 2350–2400.GetGlyphIndexhad them swapped, so syllables drew 51 glyphs late.Encoding.GetEncoding(949)threwNotSupportedExceptionunless the host registered code pages. It now usesCodePagesEncodingProvider.Instance, asMetaFiledoes.RenderTextKoreanTestsreads glyph indexes back from rendered pixels; all five cases fail without both fixes.Also carries 2bbe155 (2026-08-15): the NuGet package now ships the root README instead of a stale duplicate.
Same order fix as dalib-ts 3.2.0.
🐙 Generated via Imbas imbas@eris.co