Repository navigation
chore: remove release drafter configuration and workflow #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,36 +4,34 @@ on: | |
| push: | ||
| branches: | ||
| - main | ||
| pull_request_target: | ||
| pull_request: | ||
| types: | ||
| - edited | ||
| - opened | ||
| - reopened | ||
| - synchronize | ||
| workflow_dispatch: | ||
| inputs: | ||
| release-type: | ||
| type: choice | ||
| default: prerelease | ||
| description: Release Type | ||
| options: | ||
| - release | ||
| - prerelease | ||
| identifier: | ||
| type: string | ||
| default: rc | ||
| description: Pre-Release Identifier | ||
| required: false | ||
| include-pre-releases: | ||
| type: boolean | ||
| default: true | ||
| description: Include Pre-Releases | ||
| - labeled | ||
| - unlabeled | ||
|
|
||
| concurrency: | ||
| group: ${{ github.event_name == 'pull_request' && format('pr-{0}', github.event.number) || github.ref }} | ||
| cancel-in-progress: ${{ github.ref != 'refs/heads/main' && github.ref_type != 'tag' }} | ||
|
|
||
| jobs: | ||
| update_prerelease_draft: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. WARNING: Missing Neither Reply with |
||
| name: "Update Pre-Release Draft" | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: "Draft Pre-Release" | ||
| uses: release-drafter/release-drafter@v7.7.0 | ||
| with: | ||
| prerelease: true | ||
| prerelease-identifier: rc | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| update_release_draft: | ||
| name: "Update Release Draft" | ||
| permissions: | ||
|
|
@@ -42,10 +40,9 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: "Draft Release" | ||
| uses: release-drafter/release-drafter@v6.2.0 | ||
| uses: release-drafter/release-drafter@v7.7.0 | ||
| with: | ||
| prerelease: ${{ github.event.inputs.release-type != 'release' }} | ||
| prerelease-identifier: ${{ github.event.inputs.identifier }} | ||
| include-pre-releases: ${{ github.event.inputs.include-pre-releases }} | ||
| prerelease: false | ||
| prerelease-identifier: '' | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: Changing
pull_request_targettopull_requestbreaks the workflow for PRs from forksThe
pull_requestevent provides a read-onlyGITHUB_TOKENfor PRs from forks, but this workflow needscontents: writeandpull-requests: writepermissions to update release drafts and PR comments. Fork PRs will fail silently or with permission errors. Consider retainingpull_request_targetor adding a separatepull_requestjob with reduced permissions if fork support is needed.Reply with
@kilocode-bot fix itto have Kilo Code address this issue.