Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 0 additions & 65 deletions .github/release-drafter.yml

This file was deleted.

43 changes: 20 additions & 23 deletions .github/workflows/release-drafter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,36 +4,34 @@ on:
push:
branches:
- main
pull_request_target:
pull_request:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Changing pull_request_target to pull_request breaks the workflow for PRs from forks

The pull_request event provides a read-only GITHUB_TOKEN for PRs from forks, but this workflow needs contents: write and pull-requests: write permissions to update release drafts and PR comments. Fork PRs will fail silently or with permission errors. Consider retaining pull_request_target or adding a separate pull_request job with reduced permissions if fork support is needed.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

types:
- edited
- opened
- reopened
- synchronize
workflow_dispatch:
inputs:
release-type:
type: choice
default: prerelease
description: Release Type
options:
- release
- prerelease
identifier:
type: string
default: rc
description: Pre-Release Identifier
required: false
include-pre-releases:
type: boolean
default: true
description: Include Pre-Releases
- labeled
- unlabeled

concurrency:
group: ${{ github.event_name == 'pull_request' && format('pr-{0}', github.event.number) || github.ref }}
cancel-in-progress: ${{ github.ref != 'refs/heads/main' && github.ref_type != 'tag' }}

jobs:
update_prerelease_draft:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Missing if: conditions on jobs causes both to run for all events

Neither update_prerelease_draft nor update_release_draft has an if: condition, so both jobs execute for every trigger event (push to main, all PR event types). For push events, this creates both a release draft and a prerelease draft simultaneously, which may conflict. For PR events, both jobs also run even though only the prerelease draft may be intended. Add if: github.event_name == 'pull_request' to update_prerelease_draft and if: github.event_name == 'push' to update_release_draft.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

name: "Update Pre-Release Draft"
permissions:
contents: write
pull-requests: write
runs-on: ubuntu-latest
steps:
- name: "Draft Pre-Release"
uses: release-drafter/release-drafter@v7.7.0
with:
prerelease: true
prerelease-identifier: rc
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
update_release_draft:
name: "Update Release Draft"
permissions:
Expand All @@ -42,10 +40,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: "Draft Release"
uses: release-drafter/release-drafter@v6.2.0
uses: release-drafter/release-drafter@v7.7.0
with:
prerelease: ${{ github.event.inputs.release-type != 'release' }}
prerelease-identifier: ${{ github.event.inputs.identifier }}
include-pre-releases: ${{ github.event.inputs.include-pre-releases }}
prerelease: false
prerelease-identifier: ''
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Loading