Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
When the Etebase server rejects an expired persisted authentication token, the sync thread currently logs
Invalid token.and retries later with the same invalid session. Etebase retains the account key needed to fetch a fresh token, so the DAV bridge can recover without deleting and re-adding the user.The refreshed account session is saved before retrying, so the replacement token also survives a restart. The retry is limited to the exact
Invalid token.error and happens only once; errors such asInvalid stoken.continue to propagate normally.Fixes #341.
Testing
python -m unittest -v tests.test_token_refreshruff check .ruff format --check .check-manifest -vpython setup.py --fullnamepython setup.py --descriptionpython setup.py --long-description