Repository navigation
Conversation
Radicale 3.8 iterates over all keys returned by get_meta() without a key
and passes them to xmlutils.make_clark(), which requires the "NS:tag"
form. EtebaseCollection.get_meta() returned raw Etebase meta keys
("name", "mtime", ...), so the first PROPFIND failed with
"ValueError: not enough values to unpack". Return only the mapped DAV
property names.
Radicale 3.8 also asserts a non-empty item.last_modified in GET. Items
were created with an empty string; use the Etebase item "mtime" as an
HTTP date and fall back to the current time.
Fixes etesync#372
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Radicale 3.8 the first PROPFIND and any GET of an item return
500 Internal Server Error.PROPFIND (#372):
Radicale 3.8 iterates over all keys returned by
get_meta()(without a key) and expects DAV property names in theNS:tagform.EtebaseCollection.get_meta()returned raw Etebase meta keys (name,mtime, ...). It now returns only the mapped DAV names (D:displayname,C:calendar-description,ICAL:calendar-color,CR:addressbook-description).GET:
Items were created with
last_modified = "". It is now taken from the Etebase itemmtime(formatted as an HTTP date), falling back to the current time.Tested with Radicale 3.8.1 and etebase-server 0.14.2: PROPFIND/REPORT/PUT/GET/DELETE for calendars and address books work, changes sync both ways. Note that Radicale >= 3.5.10 also needs the changes from #365.
Fixes #372