Repository navigation
ci(pre-commit): run mypy in the project environment - #72
Merged
Merged
Conversation
The mirrors-mypy hook built its own environment with unpinned dependencies. It now installs numpy 2.5.4, whose type stubs use Python 3.12 syntax while mypy targets 3.11, so the hook failed on every commit regardless of the change. Replace it with a local hook that runs `uv run --frozen mypy src/pyneats/`, the same command as CI and `make check`, with the locked dependencies, so the hook cannot drift from CI again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
mirrors-mypypre-commit hook built its own environment with unpinned dependencies.It now installs numpy 2.5.4, whose type stubs use Python 3.12 syntax while mypy targets
3.11, so the hook failed on every commit, whatever the change (see #70, #71, which had
to use
SKIP=mypy).Replaced by a local hook that runs
uv run --frozen mypy src/pyneats/, the same commandas CI and
make check, with the locked dependencies. It cannot drift from CI again.Evidence
pre-commit run mypy --all-files).x: int = "..."), so it is notpassing vacuously.
pre-commit validate-config); this commit was made with all hooks on.