Conversation
elcreator
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title
Fix malformed application/x-www-form-urlencoded Content-Type headers
Commit message
fix(manager): correct malformed form-urlencoded Content-Type headers
PR Description
Summary
Fix malformed
Content-Typeheaders used by several XMLHttpRequest calls in the Manager.Some requests currently send:
Content-Type: application/x-www-form-urlencoded;The trailing semicolon has no parameter after it, which makes the media type malformed.
Strict HTTP request validation may reject these requests before they reach Evolution CMS.
Reproduction
On a fresh Evolution CMS installation running behind nginx with ModSecurity and OWASP Core Rule Set 4.29.0 enabled, the Manager login request was rejected with:
The rejected request contained:
Content-Type: application/x-www-form-urlencoded;After removing the trailing semicolon, the Manager login works normally without disabling ModSecurity or adding any WAF exclusions.
Changes
Removed the invalid trailing semicolon from affected Manager XMLHttpRequest headers.
Affected files:
manager/actions/category_mgr/skin/js/categories.jsmanager/media/style/common/login.tplmanager/media/style/default/chunks/welcome/StartUpScript.tplmanager/media/style/default/js/evo.jsmanager/media/style/default/login.tplExisting valid headers such as:
Content-Type: application/x-www-form-urlencoded; charset=UTF-8are left unchanged.
Expected behavior
Manager requests should send a valid media type:
Content-Type: application/x-www-form-urlencodedand should not require a ModSecurity exclusion to function.
Tested
Tested on a fresh Evolution CMS installation with:
Before the change, Manager login was blocked by CRS rule
920470with HTTP 406.After the change, login succeeds with ModSecurity still enabled.