Add custom audio track selection (pick any subset of tracks 1-6) - #185
Open
ilyambr wants to merge 2 commits into
Open
Add custom audio track selection (pick any subset of tracks 1-6)#185ilyambr wants to merge 2 commits into
ilyambr wants to merge 2 commits into
Conversation
Previously the audio track option only allowed a single track or all tracks. Adds a "Custom" mode with per-track checkboxes so specific tracks (e.g. 5 and 6) can be selected for recording/streaming/replay, reusing the existing multi-encoder/multi-mixer output plumbing.
…ing them untitled
The muxed file's audio stream title metadata was previously set to
'{source name} track N', which some editors don't surface cleanly. Matches
the naming already used in the track-selection properties UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #169.
Previously the "Audio Track" option only allowed a single track or all tracks. This adds a "Custom" mode with per-track checkboxes so specific tracks (e.g. 5 and 6) can be selected for recording/streaming/replay.
Reuses the existing multi-encoder/multi-mixer output plumbing already used by the "all tracks" mode -- doesn't change default behavior, purely additive (a new option alongside the existing single/all-track choices).
Note on the second commit: it also renames the existing "all tracks" mode's per-track encoder titles from
"{source name} track N"to"Track N", matching the naming already used in the track-selection properties UI (some editors didn't surface the old"{source name} track N"title cleanly). That's a small, independent improvement to already-existing behavior, not specific to the new Custom mode -- happy to split it into a separate PR if you'd rather review it apart from the Custom-mode addition.