feat: eXIP7.3.0.19 Post Reporting EXO-89953 - #306
Conversation
…9911 (#305) A stored per-channel plugin list replaces the defaults when a user's notification settings were ever persisted (a single toggle saves the full list), so the new PostReportPlugin was off for every such user. A dedicated NotificationSettingsUpgradePlugin wave (execute once, target 7.3.0) activates it for users with stored settings, per the plugin's Instantly default config - the same mechanism used when the previous notification plugins were introduced. Fresh users already get it by default.
boubaker
left a comment
boubaker
left a comment
There was a problem hiding this comment.
AI review — Round #1 (feature/mips integration)
Reviewed as part of the Post Reporting delivery (Meeds-io/social#6063, Meeds-io/content#909, Meeds-io/analytics#440), against board task 89911 (Report post notif enabled by default, validated 2026-09-02) and the eXip note. Cherry-pick of #305 verified patch-identical with feature/devx. One 🟡 anchored inline.
Verified conform: plugin shape identical to the NotificationSettingsUpgradePlugin sibling of this same file (same product.group.id, execute.once, async, order 1); notification.upgrade.settings.plugin.types=PostReportPlugin matches the plugin id social registers (PostReportPlugin.ID) with defaultConfig=Instantly, so updateSetting takes the addChannelPlugin branch for each of the user's active channels — the Unread activities channel is not one of them (it is a plugin-id list on ActivitySpaceWebNotificationPlugin, from which social#6053 removes the plugin), so this upgrade cannot re-enable what #6053 turned off.
Classification: N2 taken alone (a data-upgrade plugin touching every user's stored notification settings — cross-domain, no schema); the delivery as a whole is N1 via social#6063 — max-severity aggregation applies at the feature/mips integration; the approver must know that, no auto-merge on AI review alone.
🤖 Generated with Claude Code
…XO-89911 Integration review finding: a bare 7.3.0 target version ranks before 7.3.0-exo-<date> and 7.3.x-*-SNAPSHOT stored versions (Maven ComparableVersion), so shouldProceedToUpgrade skipped the wave on every instance already running a 7.3.0 build - the Mips ACC included. The target version param is dropped: execute.once already guarantees a single execution per instance (first run stores no per-plugin version, so no version check applies). Verified against UpgradeProductPlugin.shouldProceedToUpgrade and reproduced the ComparableVersion ordering with maven-artifact. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
2 participants
Integration of the Post Reporting eXip (eXIP7.3.0.19) from feature/devx — this repo's delivery commit cherry-picked (#305), verified patch-identical.
Knowledge: carried by the social integration PR.
Classification: the delivery is N1 via social (max-severity aggregation).