fix: mount and browse space drives whose display name contains a slash - EXO-89613 - #2070
Merged
Conversation
…h - EXO-89613 A Space display name holding a '/' was URL-encoded into the WebDAV drive segment as %2F, which StrictHttpFirewall rejects before the request reaches any handler and which, once decoded, split the drive into two path segments so that the identity id could no longer be read back from the path. A drive is now addressed by its Space pretty name - the very name its JCR drive is created under - while staying presented under its display name in the WebDAV displayname property. Personal drives keep the user full name. toWebDavSegment guards both against any character that cannot survive a single path segment. The legacy fallback in resolveToJcrPath now compares identity-relative paths only, so a client holding an older spelling of the drive name still resolves. The 'Map eXo Drives' drawer built the space segment client-side from the display name and is aligned on the same rule. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mkrout
approved these changes
Sep 3, 2026
exo-swf
pushed a commit
that referenced
this pull request
Sep 4, 2026
…h - EXO-89613 (#2070) A Space display name holding a '/' was URL-encoded into the WebDAV drive segment as %2F, which StrictHttpFirewall rejects before the request reaches any handler and which, once decoded, split the drive into two path segments so that the identity id could no longer be read back from the path. A drive is now addressed by its Space pretty name - the very name its JCR drive is created under - while staying presented under its display name in the WebDAV displayname property. Personal drives keep the user full name. toWebDavSegment guards both against any character that cannot survive a single path segment. The legacy fallback in resolveToJcrPath now compares identity-relative paths only, so a client holding an older spelling of the drive name still resolves. The 'Map eXo Drives' drawer built the space segment client-side from the display name and is aligned on the same rule. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Space display name holding a '/' was URL-encoded into the WebDAV drive segment as %2F, which StrictHttpFirewall rejects before the request reaches any handler and which, once decoded, split the drive into two path segments so that the identity id could no longer be read back from the path.
A drive is now addressed by its Space pretty name - the very name its JCR drive is created under - while staying presented under its display name in the WebDAV displayname property. Personal drives keep the user full name. toWebDavSegment guards both against any character that cannot survive a single path segment.
The legacy fallback in resolveToJcrPath now compares identity-relative paths only, so a client holding an older spelling of the drive name still resolves.
The 'Map eXo Drives' drawer built the space segment client-side from the display name and is aligned on the same rule.